Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dot/network: added BestBlock bool to BlockAnnounceMessage #1480

Merged
merged 4 commits into from
Mar 19, 2021

Conversation

noot
Copy link
Contributor

@noot noot commented Mar 18, 2021

Changes

  • added BestBlock bool to BlockAnnounceMessage

Tests

go test ./dot/network -short

Issues

@noot noot self-assigned this Mar 18, 2021
@noot noot changed the title fix: added BestBlock bool to BlockAnnounceMessage fix: dot/network: added BestBlock bool to BlockAnnounceMessage Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #1480 (74ba7aa) into development (dad3f3d) will decrease coverage by 0.02%.
The diff coverage is 60.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1480      +/-   ##
===============================================
- Coverage        58.61%   58.59%   -0.03%     
===============================================
  Files              151      151              
  Lines            15055    15060       +5     
===============================================
- Hits              8825     8824       -1     
- Misses            4693     4698       +5     
- Partials          1537     1538       +1     
Flag Coverage Δ
unit-tests 58.59% <60.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dot/network/block_announce.go 70.00% <50.00%> (-0.84%) ⬇️
dot/core/service.go 52.15% <100.00%> (-0.83%) ⬇️
dot/network/notifications.go 53.84% <0.00%> (-9.62%) ⬇️
dot/network/service.go 62.65% <0.00%> (+1.58%) ⬆️
dot/network/utils.go 61.53% <0.00%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad3f3d...74ba7aa. Read the comment docs.

@noot noot merged commit 09df0c3 into development Mar 19, 2021
@noot noot deleted the noot/block-announce branch March 19, 2021 16:59
github-actions bot pushed a commit that referenced this pull request Mar 19, 2021
noot: fix: dot/network: added BestBlock bool to BlockAnnounceMessage (#1480)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update BlockAnnounceMessage to contain "best block" boolean
4 participants