-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add properties and chainId on build-spec command #1520
Merged
noot
merged 23 commits into
ChainSafe:development
from
EclesioMeloJunior:feat-genesis-spec-props-and-output
Apr 16, 2021
Merged
Changes from 19 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
caa4c04
feat: Add properties and chainId on build-spec command closes #1257
EclesioMeloJunior 9f2b4f7
chore: Add output file writting on build-spec closes #1029
EclesioMeloJunior 1d2261e
chore: Add one more test case
EclesioMeloJunior fa96c67
chore: Fix test cases
EclesioMeloJunior e60be2c
chore: Fix test cases
EclesioMeloJunior df535c4
chore: Fix typo on test case
EclesioMeloJunior 82af06a
chore: Add test case to cmd/gossamer/main.go cli commands
EclesioMeloJunior 8bd7894
Merge branch 'development' into feat-genesis-spec-props-and-output
EclesioMeloJunior 59a72c4
chore: Fix lint
EclesioMeloJunior 14d9b82
chore: Improve a little bit more the tests
EclesioMeloJunior 8d36da1
Merge branch 'development' into feat-genesis-spec-props-and-output
EclesioMeloJunior 44d65c5
chore: Remove filepath.Clean on filepath.Abs
EclesioMeloJunior ea5d8c9
chore: Improve code coverage
EclesioMeloJunior 3f31a6a
Merge branch 'feat-genesis-spec-props-and-output' of github.com:Ecles…
EclesioMeloJunior 25779b0
chore: Fix typo
EclesioMeloJunior 72a8941
chore: Remove the filepath.Abs
EclesioMeloJunior 3101c6b
chore: Fix whitespace between error and verification
EclesioMeloJunior ac73507
chore: Create spec output path if not exists
EclesioMeloJunior aba012c
chore: Add test case when output dont has nested paths
EclesioMeloJunior f5d52f0
chore: Fix typo
EclesioMeloJunior 3eff2cb
Merge branch 'development' into feat-genesis-spec-props-and-output
EclesioMeloJunior c4663fd
Merge branch 'development' into feat-genesis-spec-props-and-output
arijitAD bcbe1bd
Merge branch 'development' into feat-genesis-spec-props-and-output
noot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to "rename to avoid overwriting"