fix(dot/network): Avoid printing extrinsic in TransactionMessage.

[arijitAD]

Changes

• Avoid printing extrinsics in TransactionMessage

gossamer/dot/network/service.go

Line 604 in 0932ee8

"msg", msg.String(),

• Even though msg.String() is written inside Trace this gets if we have set the logging level to Info but the log is not printed
• Wrote a go program to verify this

Code:

func printLevel(lvl string) string {
    fmt.Println("Inside: ", lvl)
    return lvl
}

func TestLogger(t *testing.T) {
    lgr := log.New("pkg", "babe")
    handler := log.StreamHandler(os.Stdout, log.TerminalFormat())
    handler = log.CallerFileHandler(handler)
    lgr.SetHandler(log.LvlFilterHandler(log.LvlInfo, handler))
    lgr.Info("Data", "Level", printLevel("Info"))
    lgr.Trace("Data", "Level", printLevel("Trace"))
}

Output:

Memory profile:

Tests

Issues

• improve gossamer memory usage #1476

Primary Reviewer

• @EclesioMeloJunior

[codecov]

Codecov Report

Merging #1728 (cccc54f) into development (9a76d39) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development    #1728      +/-   ##
===============================================
+ Coverage        58.90%   58.99%   +0.08%     
===============================================
  Files              183      183              
  Lines            19081    19081              
===============================================
+ Hits             11240    11257      +17     
+ Misses            5901     5887      -14     
+ Partials          1940     1937       -3     

Flag	Coverage Δ
unit-tests	58.99% <100.00%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
dot/network/transaction.go	46.34% <100.00%> (ø)
dot/network/connmgr.go	83.33% <0.00%> (+0.92%)	⬆️
lib/babe/babe.go	59.00% <0.00%> (+2.29%)	⬆️
lib/blocktree/leaves.go	95.12% <0.00%> (+4.87%)	⬆️
dot/state/block_notify.go	82.95% <0.00%> (+9.09%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a76d39...cccc54f. Read the comment docs.

[github-actions]

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀