feature(lib/runtime): implement ext_offchain_timestamp and ext_offchain_sleep_until
#1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omar391
requested review from
arijitAD,
EclesioMeloJunior,
edwardmack,
jimjbrettj,
noot and
timwu20
as code owners
|
|
EclesioMeloJunior
requested changes
Sep 24, 2021
noot
reviewed
Sep 24, 2021
noot
reviewed
Sep 24, 2021
noot
reviewed
Sep 24, 2021
timwu20
approved these changes
Sep 28, 2021
noot
reviewed
Oct 1, 2021
noot
approved these changes
Oct 1, 2021
noot
reviewed
Oct 1, 2021
There was a problem hiding this comment.
actually, tests are failing due to this:
lib/runtime/wasmer/imports_test.go:75:54: time.Now().UnixMilli undefined (type time.Time has no field or method UnixMilli)
lib/runtime/wasmer/imports.go:1565:20: undefined: time.UnixMilli
however time.UnixMilli is defined: https://pkg.go.dev/time#UnixMilli can you update the go.mod version to go 1.17? (and the README)
EclesioMeloJunior
requested changes
Oct 15, 2021
EclesioMeloJunior
approved these changes
Oct 18, 2021
edwardmack
approved these changes
Oct 18, 2021
|
@omar391 can you make sure all the checks pass and merge this in? |
EclesioMeloJunior
requested changes
Nov 8, 2021
arijitAD
reviewed
Nov 10, 2021
EclesioMeloJunior
approved these changes
Nov 11, 2021
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
timwu20
pushed a commit
to timwu20/gossamer
that referenced
this pull request
Dec 6, 2021
…chain_sleep_until` (ChainSafe#1806) * Issue#1508 First commit * Changed interface name + Added testcase * Removed leftover comments * Updated host api runtime + Added testcase * add support for polkadot runtime v0.9.10 * cleanup * Removed testcases temporarily * Updated base Go version to 1.17 to resolve time.UnixMilli issues * Updated go.mod * Removed unused context * Updated go-version to 1.17.x in github workflows * Updated go version in the Dockerfile * added .devcontainer in the gitignore * Linked related issue for the unimplemented unit test * Fixed CGO issues * Fixed lint issues * Fixed unit tests Co-authored-by: noot <elizabethjbinks@gmail.com> Co-authored-by: noot <36753753+noot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ext_offchain_timestampmethodext_offchain_sleep_untilmethodRuntimeStorageAPIinterface intoOffchainStorageAPITests
Issues
ext_offchain_timestampbut it seems there are some issues with FFI calling which I need to discuss with the teamext_offchain_timestamp_version_1#1795, implement remaining offchain worker API #1508, Implement unit test forext_offchain_timestamp_version_1andext_offchain_sleep_until_version_1#1902Primary Reviewer