chore(ci): remove dependency on scripts/ci.go
#1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove outdated ci.go test - Build binary with `-trimpath` - Build binary without changing directory - Install binary by executing build step and moving built binary
Codecov Report
@@ Coverage Diff @@
## development #1964 +/- ##
============================================
Coverage 60.27% 60.27%
============================================
Files 180 180
Lines 18189 18189
============================================
+ Hits 10963 10964 +1
+ Misses 5415 5410 -5
- Partials 1811 1815 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
qdm12
requested review from
arijitAD,
EclesioMeloJunior,
edwardmack,
jimjbrettj,
kishansagathiya,
noot,
omar391 and
timwu20
as code owners
omar391
reviewed
Nov 3, 2021
EclesioMeloJunior
approved these changes
Nov 3, 2021
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
timwu20
pushed a commit
to timwu20/gossamer
that referenced
this pull request
Dec 6, 2021
- Remove unused `scripts/ci.sh` - Dockerfile: build Go binary without `scripts/ci.go` - Build Go binary with `-trimpath` - Makefile: - remove outdated `ci.go test` from Makefile - build binary without `scripts/ci.go` - build binary without changing directory - `install` binary by executing `build` target and just `mv` the built binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
scripts/ci.shscripts/ci.go-trimpathci.go testfrom Makefilescripts/ci.goinstallbinary by executingbuildtarget and justmvthe built binaryTests
Whole CI passing
Issues
Related to a CI issue Omar had with
go installvsgo build.Primary Reviewer