Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create nextEpochMap type #2633

Conversation

timwu20
Copy link
Contributor

@timwu20 timwu20 commented Jun 30, 2022

Changes

  • nextEpochMap type which uses generics

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

Primary Reviewer

@EclesioMeloJunior

@EclesioMeloJunior
Copy link
Member

Cool stuff 👍 ! Feel free to merge your modifications!

dot/state/epoch.go Outdated Show resolved Hide resolved
dot/state/epoch.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

❗ No coverage uploaded for pull request base (eclesio/fix/block-production-for-epochs@9b69ffb). Click here to learn what that means.
The diff coverage is n/a.

@@                            Coverage Diff                             @@
##             eclesio/fix/block-production-for-epochs    #2633   +/-   ##
==========================================================================
  Coverage                                           ?   62.01%           
==========================================================================
  Files                                              ?      215           
  Lines                                              ?    28399           
  Branches                                           ?        0           
==========================================================================
  Hits                                               ?    17613           
  Misses                                             ?     9041           
  Partials                                           ?     1745           
Flag Coverage Δ
unit-tests 62.01% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b69ffb...380aec6. Read the comment docs.

@timwu20 timwu20 marked this pull request as ready for review July 4, 2022 18:18
@timwu20 timwu20 merged commit 257c2bb into eclesio/fix/block-production-for-epochs Jul 4, 2022
@timwu20 timwu20 deleted the tim/fix/block-production-for-epochs branch July 4, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants