Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(utils): replace all the unneeded spec usage for westend-(dev|local) runtime #3014

Merged
merged 40 commits into from
Jan 12, 2023

Conversation

EclesioMeloJunior
Copy link
Member

Changes

  • Replace the usage of all GetGssmrGenesis* utils functions for GetWestendDevGenesisPath() in order to remove unneeded spec usage

Tests

N/A

Issues

Primary Reviewer

@EclesioMeloJunior EclesioMeloJunior changed the title chore: replace all the unneeded spec usage for westend-dev runtime chore(utils): replace all the unneeded spec usage for westend-dev runtime Jan 4, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #3014 (6ac7429) into development (841636e) will increase coverage by 0.07%.
The diff coverage is 18.18%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #3014      +/-   ##
===============================================
+ Coverage        51.40%   51.48%   +0.07%     
===============================================
  Files              219      219              
  Lines            28036    28011      -25     
===============================================
+ Hits             14412    14421       +9     
+ Misses           12339    12305      -34     
  Partials          1285     1285              

lib/utils/utils.go Outdated Show resolved Hide resolved
tests/rpc/rpc_01-system_test.go Outdated Show resolved Hide resolved
tests/rpc/rpc_01-system_test.go Outdated Show resolved Hide resolved
tests/rpc/rpc_03-chain_test.go Outdated Show resolved Hide resolved
tests/rpc/rpc_03-chain_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, besides what quentin already commented on this looks good to me

@EclesioMeloJunior EclesioMeloJunior requested review from qdm12 and timwu20 and removed request for qdm12 January 10, 2023 14:45
@EclesioMeloJunior EclesioMeloJunior changed the title chore(utils): replace all the unneeded spec usage for westend-dev runtime chore(utils): replace all the unneeded spec usage for westend-(dev|local) runtime Jan 10, 2023
Copy link
Contributor

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

lib/utils/utils.go Outdated Show resolved Hide resolved
tests/rpc/rpc_01-system_test.go Outdated Show resolved Hide resolved
EclesioMeloJunior and others added 3 commits January 11, 2023 15:19
Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
@EclesioMeloJunior EclesioMeloJunior merged commit 07892b1 into development Jan 12, 2023
@EclesioMeloJunior EclesioMeloJunior deleted the eclesio/remove-unneeded-spec-usage branch January 12, 2023 13:03
Copy link

🎉 This PR is included in version 0.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants