Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integration with js-libp2p #21

Merged

Conversation

vasco-santos
Copy link
Collaborator

@vasco-santos vasco-santos commented May 24, 2019

In the context of integrating gossipsub into js-libp2p libp2p/js-libp2p#365, some problems appeared and this PR addresses them.

@vasco-santos vasco-santos marked this pull request as ready for review May 24, 2019 11:30
@codecov-io
Copy link

codecov-io commented May 24, 2019

Codecov Report

Merging #21 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   83.18%   83.22%   +0.03%     
==========================================
  Files           8        8              
  Lines         452      453       +1     
==========================================
+ Hits          376      377       +1     
  Misses         76       76
Impacted Files Coverage Δ
src/pubsub.js 92.56% <100%> (+0.06%) ⬆️
src/heartbeat.js 70.27% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf99d47...f894281. Read the comment docs.

Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wemeetagain wemeetagain merged commit b7094c7 into ChainSafe:master May 24, 2019
@vasco-santos vasco-santos deleted the fix/integration-with-js-libp2p branch May 24, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants