Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate gossipsub by default #365

Merged
merged 5 commits into from Jul 31, 2019

Conversation

@vasco-santos
Copy link
Member

commented May 24, 2019

BREAKING CHANGE: new configuration for deciding the implementation of pubsub to be used.
In this context, the experimental flags were also removed.

This PR modified the configuration of a libp2p node, in order to allow the selection of the pubsub implementation to use. Also Gossipsub was added as the default pubsub implementation in the tests

Needs:

Unblocks:

@vasco-santos vasco-santos changed the title feat: integrate gossipsub by default [WIP] feat: integrate gossipsub by default May 24, 2019
@vasco-santos vasco-santos force-pushed the feat/integrate-gossipsub-by-default branch 2 times, most recently from 3fc3adc to e753125 May 24, 2019
@vasco-santos

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

@vasco-santos vasco-santos referenced this pull request May 24, 2019
3 of 3 tasks complete
@vasco-santos vasco-santos force-pushed the feat/integrate-gossipsub-by-default branch from e753125 to e238d43 Jul 9, 2019
@vasco-santos vasco-santos requested a review from jacobheun Jul 10, 2019
Copy link
Contributor

left a comment

Just some minor comments, but overall this looks good.

test/pubsub.node.js Outdated Show resolved Hide resolved
test/pubsub.node.js Outdated Show resolved Hide resolved
@vasco-santos vasco-santos force-pushed the feat/integrate-gossipsub-by-default branch from 4edf353 to 4dd2e46 Jul 11, 2019
src/pubsub.js Show resolved Hide resolved
@vasco-santos vasco-santos force-pushed the feat/integrate-gossipsub-by-default branch from 913c809 to 34f663a Jul 11, 2019
src/index.js Outdated Show resolved Hide resolved
@jacobheun jacobheun force-pushed the feat/integrate-gossipsub-by-default branch from 9c48b1b to 2b76101 Jul 12, 2019
@vasco-santos vasco-santos force-pushed the feat/integrate-gossipsub-by-default branch 3 times, most recently from 1dd19c2 to 3790ca8 Jul 15, 2019
Copy link
Contributor

left a comment

1 usability thing with configuration, otherwise I like where this is at.

if (this._config.EXPERIMENTAL.pubsub) {
this.pubsub = pubsub(this)
// start pubsub
if (this._config.pubsub.enabled) {

This comment has been minimized.

Copy link
@jacobheun

jacobheun Jul 24, 2019

Contributor

@vasco-santos what do you think about changing this logic a bit. I think if this._modules.pubsub is set, and this._config.pubsub.enabled !== false we should use pubsub. This would avoid people needing to add and enable it. We do this for discovery. If you've configured it, there's a really good chance you want to use it :)

This comment has been minimized.

Copy link
@vasco-santos

vasco-santos Jul 24, 2019

Author Member

I agree, this is a better dev ex

@vasco-santos vasco-santos force-pushed the feat/integrate-gossipsub-by-default branch from e45b1bb to c2cd663 Jul 26, 2019
@jacobheun jacobheun referenced this pull request Jul 29, 2019
19 of 19 tasks complete
@vasco-santos vasco-santos changed the title [WIP] feat: integrate gossipsub by default feat: integrate gossipsub by default Jul 30, 2019
BREAKING CHANGE: new configuration for deciding the implementation of pubsub to be used.
In this context, the experimental flags were also removed.
@vasco-santos vasco-santos force-pushed the feat/integrate-gossipsub-by-default branch from c5be8dd to 65866b2 Jul 30, 2019
@vasco-santos

This comment has been minimized.

Copy link
Member Author

commented Jul 30, 2019

@jacobheun gossipsub was released 🎉

Just rebased and updated the PR

Copy link
Contributor

left a comment

Woot! I'll get an rc cut.

@jacobheun jacobheun merged commit 791f39a into master Jul 31, 2019
5 of 6 checks passed
5 of 6 checks passed
codecov/patch 96.55% of diff hit (target 97.03%)
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
Windows Tests #155 succeeded
Details
bundlesize ./dist/index.min.js: 206.61KB < maxSize 220KB (gzip)
Details
codecov/project 97.03% (+<.01%) compared to 65d5285
Details
@jacobheun jacobheun deleted the feat/integrate-gossipsub-by-default branch Jul 31, 2019
@jacobheun

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

0.26.0-rc.0 is out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.