Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gs1.1 peer exchange #100

Merged
merged 5 commits into from
Jul 22, 2020
Merged

gs1.1 peer exchange #100

merged 5 commits into from
Jul 22, 2020

Conversation

wemeetagain
Copy link
Member

@wemeetagain wemeetagain commented Jul 1, 2020

Implements https://github.com/libp2p/specs/blob/master/pubsub/gossipsub/gossipsub-v1.1.md#prune-backoff-and-peer-exchange

Follows go-libp2p-pubsub implementation closely

Depends on libp2p/js-libp2p#683
As noted in a comment there, we now require the libp2p repo as a full-fledged dependency, due to needing to openAndCertify the raw envelope.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2020

Codecov Report

Merging #100 into gsv1.1 will increase coverage by 5.88%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsv1.1     #100      +/-   ##
==========================================
+ Coverage   75.93%   81.81%   +5.88%     
==========================================
  Files          22        1      -21     
  Lines        1342       11    -1331     
==========================================
- Hits         1019        9    -1010     
+ Misses        323        2     -321     
Impacted Files Coverage Δ
src/score/computeScore.js
src/score/messageDeliveries.js
src/messageCache.js
src/utils/shuffle.js
src/index.js
aegir.js
src/score/index.js
src/utils/index.js
src/message/rpc.proto.js
src/score/constants.js
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89bf606...40b8974. Read the comment docs.

@wemeetagain
Copy link
Member Author

@vasco-santos This is ready for re-review. Codecov is giving an ❌ but we'll tackle the tests in another PR (in progress 😃)

package.json Outdated Show resolved Hide resolved
ts/index.ts Outdated Show resolved Hide resolved
ts/index.ts Show resolved Hide resolved
@wemeetagain wemeetagain merged commit 29f364f into gsv1.1 Jul 22, 2020
@wemeetagain wemeetagain deleted the cayman/gs1.1-px branch July 22, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants