Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gs1.1: configurable overlay params #112

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

wemeetagain
Copy link
Member

@wemeetagain wemeetagain commented Jul 21, 2020

Add GossipsubD* constants as configurable options. Defaults to the contant value, can be overwritten for testing or other purposes.

@wemeetagain wemeetagain changed the title Cayman/configurable overlay params Configurable overlay params Jul 21, 2020
@wemeetagain wemeetagain force-pushed the cayman/configurable-overlay-params branch from 1651261 to 9351e32 Compare July 21, 2020 18:35
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2020

Codecov Report

Merging #112 into gsv1.1 will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsv1.1     #112      +/-   ##
==========================================
+ Coverage   75.93%   75.94%   +0.01%     
==========================================
  Files          22       22              
  Lines        1342     1343       +1     
==========================================
+ Hits         1019     1020       +1     
  Misses        323      323              
Impacted Files Coverage Δ
src/heartbeat.js 62.58% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89bf606...9351e32. Read the comment docs.

@wemeetagain wemeetagain changed the title Configurable overlay params gs1.1: configurable overlay params Jul 21, 2020
Copy link
Collaborator

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wemeetagain wemeetagain merged commit 3b52a72 into gsv1.1 Jul 22, 2020
@wemeetagain wemeetagain deleted the cayman/configurable-overlay-params branch July 22, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants