feat: type safe metric labels #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #479 +/- ##
==========================================
- Coverage 81.38% 81.37% -0.02%
==========================================
Files 48 48
Lines 12275 12261 -14
Branches 1292 1292
==========================================
- Hits 9990 9977 -13
+ Misses 2285 2284 -1 ☔ View full report in Codecov by Sentry. |
nflaig
commented
Jan 3, 2024
| @@ -328,10 +315,9 @@ export function getMetrics ( | |||
| labelNames: ['hit'] | |||
| }), | |||
|
|
|||
| asyncValidationDelayFromFirstSeenSec: register.histogram<{ topic: TopicLabel }>({ | |||
| asyncValidationDelayFromFirstSeenSec: register.histogram({ | |||
There was a problem hiding this comment.
Label value is not set for this metric
js-libp2p-gossipsub/src/metrics.ts
Line 793 in eb53ea9
Topic might not be available when setting the metric hence I updated the type instead of updating the code and setting the topic.
| @@ -883,9 +869,9 @@ export function getMetrics ( | |||
| }, | |||
|
|
|||
| onDuplicateMsgDelivery (topicStr: TopicStr, deliveryDelayMs: number, isLateDelivery: boolean): void { | |||
| this.duplicateMsgDeliveryDelay.observe(deliveryDelayMs / 1000) | |||
| const topic = this.toTopic(topicStr) | |||
| this.duplicateMsgDeliveryDelay.observe({ topic }, deliveryDelayMs / 1000) | |||
There was a problem hiding this comment.
Label was defined in type but not set. I'd assume this was just an oversight as topic is always available here.
nflaig
changed the title
nflaig
force-pushed
the
nflaig/type-safe-metric-labels
branch
from
086efa0
to
59bd077
Compare
dapplion
approved these changes
Jan 4, 2024
wemeetagain
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ChainSafe/lodestar#6201 for motivation / rationale