fix: remove abortable iterator #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbortableSource is slow because it races promises against every chunk causing extra async work. It's only really necessary if we're going to pass the source off to another component. Here we don't do that so it's simpler to just add a listener for the abort event and close the stream.
achingbrain
commented
Feb 2, 2024
Comment on lines
66
to
67
| // similar to pushable.end() but clear the internal buffer | ||
| await this.pushable.return() |
There was a problem hiding this comment.
I don't think this is necessary since the pushable is only referenced by this stream class so everything will be garbage collected shortly after the close method is called on this OutboundStream instance.
Suggested change
| // similar to pushable.end() but clear the internal buffer | |
| await this.pushable.return() |
It's also worth noting that any queued messages will not be sent if you call .return instead of .end but this method is only called after the remote peer has already disconnected so it's not a big deal.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #488 +/- ##
==========================================
- Coverage 81.40% 81.39% -0.02%
==========================================
Files 48 48
Lines 12325 12333 +8
Branches 1301 1302 +1
==========================================
+ Hits 10033 10038 +5
- Misses 2292 2295 +3 ☔ View full report in Codecov by Sentry. |
|
#434 can probably be closed if this is merged. |
wemeetagain
approved these changes
Feb 5, 2024
This was referenced Feb 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbortableSource is slow because it races promises against every chunk causing extra async work.
It's only really necessary if we're going to pass the source off to another component.
Here we don't do that so it's simpler to just add a listener for the abort event and close the stream.