Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gossipsub v1.1 #82

Merged
merged 140 commits into from
Aug 25, 2020
Merged

Gossipsub v1.1 #82

merged 140 commits into from
Aug 25, 2020

Conversation

wemeetagain
Copy link
Member

@wemeetagain wemeetagain commented Jun 3, 2020

Open draft PR for visibility

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #82 into master will increase coverage by 11.66%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #82       +/-   ##
===========================================
+ Coverage   80.00%   91.66%   +11.66%     
===========================================
  Files           1        2        +1     
  Lines          10       24       +14     
===========================================
+ Hits            8       22       +14     
  Misses          2        2               
Impacted Files Coverage Δ
.aegir.js 100.00% <100.00%> (ø)
test/utils/index.js 81.81% <100.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28d214e...2754660. Read the comment docs.

@vasco-santos
Copy link
Collaborator

vasco-santos commented Jun 4, 2020

@wemeetagain me and @jacobheunhave been adopting smaller PRs rather than big changes lately, in order to ease reviews.

Perhaps we can do something similar here, what do you think? Divisions that make sense of course, like dividing by parts that work for themselves and we merge everything to a branch. When everything is ready, we can merge to master.

Is this reasonable for you?

@wemeetagain
Copy link
Member Author

Thats a great idea. Definitely a fan of the smaller PRs.
I'll wipe the slate clean on this branch and keep this draft PR open for visibility, and submit smaller PRs to this branch.

@wemeetagain wemeetagain reopened this Jun 17, 2020
@vasco-santos vasco-santos changed the title [WIP] Gossipsub v1.1 Gossipsub v1.1 Aug 25, 2020
@vasco-santos vasco-santos marked this pull request as ready for review August 25, 2020 17:01
Copy link
Collaborator

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vasco-santos vasco-santos merged commit a31ca5b into master Aug 25, 2020
@vasco-santos vasco-santos deleted the gsv1.1 branch August 25, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants