Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gs1.1 adaptive gossip #94

Merged
merged 1 commit into from
Jun 22, 2020
Merged

gs1.1 adaptive gossip #94

merged 1 commit into from
Jun 22, 2020

Conversation

wemeetagain
Copy link
Member

Implements https://github.com/libp2p/specs/blob/master/pubsub/gossipsub/gossipsub-v1.1.md#adaptive-gossip-dissemination

  • Closely follows the go-libp2p-pubsub implementation
  • Adaptive gossip dissemination in _emitGossip
  • fixes up the fanout peer handling in heartbeat
    • includes bugfix in the heartbeat where we were deleting fanout peers who are still in the topic (yikes)
  • Add hasGossipProtocol utility function, replace where appropriate

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2020

Codecov Report

Merging #94 into gsv1.1 will increase coverage by 1.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           gsv1.1      #94      +/-   ##
==========================================
+ Coverage   80.00%   81.81%   +1.81%     
==========================================
  Files           1        1              
  Lines          10       11       +1     
==========================================
+ Hits            8        9       +1     
  Misses          2        2              
Impacted Files Coverage Δ
test/utils/index.js 81.81% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25f9d0...0c56763. Read the comment docs.

Copy link
Collaborator

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wemeetagain wemeetagain merged commit 12b4fa3 into gsv1.1 Jun 22, 2020
@wemeetagain wemeetagain deleted the cayman/gs1.1-adaptive-gossip branch June 22, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants