Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Typescript #24

Closed
ansermino opened this issue Oct 31, 2018 · 5 comments
Closed

Migrate to Typescript #24

ansermino opened this issue Oct 31, 2018 · 5 comments

Comments

@ansermino
Copy link
Member

There seems to be some good discussion around this in the ethereumjs organization, as well as other JS blockchain projects. There is an additional barrier of entry, but it would seem that the benefits are worth it. We would have a huge advantage by making the switch now, although it would certainly could be reconsidered further down the road.

ethereumjs/organization#28
ethereumjs/ethereumjs-client#10
https://www.typescriptlang.org/docs/handbook/migrating-from-javascript.html

@GregTheGreek
Copy link
Member

Love the idea. Let's make a typescript branch.

@dbkbali
Copy link

dbkbali commented Oct 31, 2018

Definitely will improve code quality and typescript transpiles to js. So everyone should be happy😁

@priom
Copy link
Member

priom commented Oct 31, 2018

Let's migrate the whole project to TS, will be easier to maintain the project and releases.

@GregTheGreek
Copy link
Member

After having a call with the Ethereum-js /shasper-js team I think it would be best to migrate to typescript. Moving to high priority before the project gets too large.

This was referenced Nov 19, 2018
@GregTheGreek GregTheGreek added this to the Typescript Conversion milestone Nov 25, 2018
@GregTheGreek
Copy link
Member

Update:

New milestone & project setup for this. Currently #34 is being worked on by me to get the core/state directory converted. Will move outwards.

GregTheGreek added a commit that referenced this issue Nov 30, 2018
wemeetagain added a commit that referenced this issue Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants