Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peer score store to use PeerAction and decay #2074

Merged
merged 1 commit into from
Feb 21, 2021

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Feb 19, 2021

  • Change individual score events to 4 levels of PeerAction. Each component reporting the peer decides locally how grave is the offense
  • Scores start at 0 and decay over time
  • Consumers of the score modules need not specify specific scores, but a state Healthy, Banned

Specific numbers are borrowed from Lighthouse

@github-actions github-actions bot added the scope-networking All issues related to networking, gossip, and libp2p. label Feb 19, 2021
@codeclimate
Copy link

codeclimate bot commented Feb 19, 2021

Code Climate has analyzed commit 6a42411 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.

@lgtm-com
Copy link

lgtm-com bot commented Feb 19, 2021

This pull request introduces 1 alert when merging ca37eae into 31e72d0 - view on LGTM.com

new alerts:

  • 1 for Expression has no effect

- Change individual score events to 4 levels of PeerAction. Each component reporting the peer decides locally how grave is the offence
- Scores start at 0 and decay over time
- Consumers of the score modules need not specify specific scores, but a state `Healthy`, `Banned`
@ChainSafe ChainSafe deleted a comment from lgtm-com bot Feb 21, 2021
@lgtm-com
Copy link

lgtm-com bot commented Feb 21, 2021

This pull request introduces 1 alert when merging 6a42411 into b70222d - view on LGTM.com

new alerts:

  • 1 for Expression has no effect

@wemeetagain wemeetagain merged commit 75c9141 into master Feb 21, 2021
@wemeetagain wemeetagain deleted the dapplion/peer-score branch February 21, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-networking All issues related to networking, gossip, and libp2p.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants