Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove profiler from spec tests utils #2324

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Apr 2, 2021

Motivation

  • v8-profiler-next adds a noticeable time to installation which is apparent in blst-ts which triggers 46 runs per commit.
  • We have other better ways to profile Lodestar, be Tuyen's perf tests or just taking a profile on demand on a running node
  • If one needs to profile a spec test, can do so wrapping the function to test in the consumer side, outside of this util.

Description

Remove profiler code from spec test utils

@codeclimate
Copy link

codeclimate bot commented Apr 2, 2021

Code Climate has analyzed commit fa3b13c and detected 0 issues on this pull request.

View more on Code Climate.

@lgtm-com
Copy link

lgtm-com bot commented Apr 2, 2021

This pull request introduces 2 alerts when merging fa3b13c into cfd51c3 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@wemeetagain wemeetagain merged commit a153938 into master Apr 2, 2021
@wemeetagain wemeetagain deleted the dapplion/remove-spec-profiler branch April 2, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants