Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify SyncCommittee signatures in batch #2625

Merged
merged 2 commits into from Jun 3, 2021
Merged

Verify SyncCommittee signatures in batch #2625

merged 2 commits into from Jun 3, 2021

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Jun 3, 2021 •
edited

Motivation

A continuation of #2617

Description

  • when getting sync committee signature set, previous slot should be from the block instead of state to make sure it's correct
  • signed roots of sync committee signatures are only known after we run state transition for all blocks in segment
  • revert Fix signature verification at fork boundary #2624 as it's not necessary anymore

Steps to test or reproduce

  • ./bin/lodestar beacon --network oonoonba

@codeclimate
Copy link

codeclimate bot commented Jun 3, 2021 •
edited

Code Climate has analyzed commit 4951a92 and detected 0 issues on this pull request.

View more on Code Climate.

@twoeths
Copy link
Contributor Author

twoeths commented Jun 3, 2021

synced fine now
Screen Shot 2021-06-03 at 16 52 01

@twoeths twoeths marked this pull request as ready for review June 3, 2021 09:54
dapplion
dapplion reviewed Jun 3, 2021
View reviewed changes
packages/beacon-state-transition/src/altair/block/processSyncCommittee.ts Outdated
if (signatureSet !== null && !verifySignatureSet(signatureSet)) {
throw Error("Sync committee signature invalid");
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-add signature verification

@twoeths twoeths force-pushed the tuyen/verify-sync-committee-signatures-in-batch branch from e4c6c45 to e83cd27 Compare June 3, 2021 10:37
@dapplion dapplion merged commit c7b1fcf into master Jun 3, 2021
@dapplion dapplion deleted the tuyen/verify-sync-committee-signatures-in-batch branch June 3, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@mpetrunic mpetrunic Awaiting requested review from mpetrunic

@wemeetagain wemeetagain Awaiting requested review from wemeetagain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@twoeths @dapplion