Fix remote signing #4502
Merged
Fix remote signing #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
dapplion
reviewed
Sep 3, 2022
| }; | ||
| } | ||
|
|
||
| async signAttestationSelectionProof(pubkey: BLSPubkeyMaybeHex, slot: Slot): Promise<BLSSignature> { | ||
| const domain = this.config.getDomain(slot, DOMAIN_SELECTION_PROOF); | ||
| const signingRoot = computeSigningRoot(ssz.Slot, slot, domain); | ||
|
|
||
| return await this.getSignature(pubkey, signingRoot); | ||
| const signableMessage: SignableMessage = { |
There was a problem hiding this comment.
If the web3signer is not enabled, all this objects are being created for nothing right?
There was a problem hiding this comment.
Updated to only create the Singable messages when web3signer is enabled.
There was a problem hiding this comment.
@dapplion Your recent changes now makes it such that the objects are being created even when web3signer is not enabled. Is that intentional/okay now?
|
Please add an e2e test that run the web3signer docker container and request signatures for all available objects. I would really need to have programmatic certainty that this works before merging. |
dapplion
reviewed
Sep 13, 2022
| block: ssz.altair.BeaconBlock.toJson(data.block as altair.BeaconBlock), | ||
| }; | ||
| } else { | ||
| throw new Error(`version ${data.version} not supported by remote signer`); |
There was a problem hiding this comment.
What about the bellatrix fork? Using this pattern doesn't scale and will be painful to mantain
There was a problem hiding this comment.
I basically followed the pattern used in lighthouse here. Had an older version so bellatrix was not included. Added it now. As regards observation about maintenance. I'll revisit this after setting up all the tests
There was a problem hiding this comment.
Yet to do the final sanity check but it occurred to me, that maybe the maintenance won't be too hard. Because:
- Having another fork is a coordinated effort that will be planned out and include coordinated code changes
- Even if lodestar can handle new forks without code changes, it should not, because it also depends on making sure that the Web3Signer has been updated to also handle the new fork. If not, lodestar will pass the call to web3signer but it will fail.
There was a problem hiding this comment.
Right I wasnt aware of how weird the web3signer request types are 😅 made such that any fork after bellatrix with use the bellatrix path
dapplion
reviewed
Sep 14, 2022
| return getRemoteSigners(args); | ||
| } else { | ||
| return indexes.map((index) => ({type: SignerType.Local, secretKey: interopSecretKey(index)})); | ||
| } |
There was a problem hiding this comment.
What's the purpose of this? I don't follow
There was a problem hiding this comment.
To consume the interop indexes from the web3signer you should load the interop keystores in the web3signer and then use .fetch
wemeetagain
approved these changes
Sep 14, 2022
dapplion
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Using remote signer currently does not work. This is because the web3signer URL is different from what lodestar expects.
PS: currently draft PR as the branch still need to be tested on goerli test net.
Description
Update implementation to use correct web3signer endpoints.
Closes #4424
Steps to test or reproduce