-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remote signing #4502
Merged
Merged
Fix remote signing #4502
Changes from 19 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
8b25b21
Merge branch 'unstable' into dadepo/fix-remote-signer-endpoint
dadepo 00fe74f
updated endpoint to retrieve pub keys
dadepo 05a9aa1
exposing previous version in fork info
dadepo 35ad349
passed in genesisValidatorsRoot to ValidatorStore
dadepo 930f46a
Make signable payload available for external signer
dadepo ced0343
renamed signableRequest to signableMessage
dadepo d6f1bef
AGGREGATION_SLOT is now signable by the remote signer
dadepo f532fc6
tests fixed
dadepo fc13236
add a way to serialize payload that have ssz values
dadepo 36ee913
Merge branch 'unstable' into dadepo/fix-remote-signer-endpoint
dadepo 5d9e3a4
Merge branch 'unstable' into dadepo/fix-remote-signer-endpoint
dadepo 1175260
some formatting
dadepo dfa382d
merged in unstable and resolved conflicts
dadepo 1275f86
only construct signable message if remote signer is used
dadepo 29e8bd8
merged in unstable; resolved conflicts
dadepo e03298b
Merge branch 'unstable' into dadepo/fix-remote-signer-endpoint
dadepo e92e251
enable remote signer also for dev runs
dadepo beeca38
process request object for BLOCK_V2 type
dadepo 2f77cf9
Blocks are now being signed by the remote signer too
dadepo a304885
Add base for web3signer signature test
dapplion f0768b3
Ensure process is killed
dapplion e344acf
Use testcontainers for managing containers in tests
dadepo bf6c7eb
fix lint errors
dadepo 2e4aada
Added bellatrix
dadepo 35a8e56
Add test for signAttestation
dadepo fb2af6c
Add test for signVoluntaryExit
dadepo 70bbad8
Added test for signSyncCommitteeSelectionProof
dadepo c3ac872
merged in unstable, resolve conflicts
dadepo 4a3f045
typos fixes
dadepo 33560f8
using assertSameSignature for all tests
dadepo 586a6d4
Added test for signAttestationSelectionProof
dadepo 87c944e
add test for signBlock
dadepo 2d1bd21
added tests for signSyncCommitteeSignature
dadepo bd18f82
added test for signContributionAndProof and signAggregateAndProof
dadepo b0d80f4
Remove remote signing tests as it does not test a real remote signer
dadepo 6581fce
Review PR
dapplion f737bec
setting timeout might not be necessary. Remove it. Readd, if needed
dadepo 82b535f
Fix web3signer paths
dapplion 006a7c0
Remove permissions from tmp dir
dapplion 1923153
Test prevVersion
dapplion 4376721
Set 755
dapplion File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this? I don't follow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To consume the interop indexes from the web3signer you should load the interop keystores in the web3signer and then use .fetch