Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default file options to save debug level log #4531

Merged
merged 2 commits into from Sep 11, 2022

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Sep 10, 2022

This PR updates the default file options to always debug log with log rotation set.

To disable log, now one has to pass --logFile none and to disable log rotation one has to pass --logRotateFiles 0.

Closes #4527

@g11tech g11tech requested a review from a team as a code owner September 10, 2022 07:51
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 21d8457 Previous: 65b38ee Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.6274 ms/op 2.0655 ms/op 1.27
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 83.457 us/op 71.801 us/op 1.16
BLS verify - blst-native 2.2316 ms/op 1.8555 ms/op 1.20
BLS verifyMultipleSignatures 3 - blst-native 4.4752 ms/op 3.8096 ms/op 1.17
BLS verifyMultipleSignatures 8 - blst-native 10.089 ms/op 8.1954 ms/op 1.23
BLS verifyMultipleSignatures 32 - blst-native 34.773 ms/op 29.693 ms/op 1.17
BLS aggregatePubkeys 32 - blst-native 47.111 us/op 39.098 us/op 1.20
BLS aggregatePubkeys 128 - blst-native 184.25 us/op 152.89 us/op 1.21
getAttestationsForBlock 197.70 ms/op 170.27 ms/op 1.16
isKnown best case - 1 super set check 506.00 ns/op 430.00 ns/op 1.18
isKnown normal case - 2 super set checks 473.00 ns/op 416.00 ns/op 1.14
isKnown worse case - 16 super set checks 510.00 ns/op 414.00 ns/op 1.23
CheckpointStateCache - add get delete 11.459 us/op 8.9150 us/op 1.29
validate gossip signedAggregateAndProof - struct 5.4897 ms/op 4.2718 ms/op 1.29
validate gossip attestation - struct 2.7448 ms/op 2.0335 ms/op 1.35
pickEth1Vote - no votes 2.9728 ms/op 2.1438 ms/op 1.39
pickEth1Vote - max votes 28.127 ms/op 19.461 ms/op 1.45
pickEth1Vote - Eth1Data hashTreeRoot value x2048 15.890 ms/op 11.509 ms/op 1.38
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 24.974 ms/op 21.778 ms/op 1.15
pickEth1Vote - Eth1Data fastSerialize value x2048 1.8445 ms/op 1.6318 ms/op 1.13
pickEth1Vote - Eth1Data fastSerialize tree x2048 14.991 ms/op 13.216 ms/op 1.13
bytes32 toHexString 1.1960 us/op 1.0430 us/op 1.15
bytes32 Buffer.toString(hex) 786.00 ns/op 681.00 ns/op 1.15
bytes32 Buffer.toString(hex) from Uint8Array 1.1380 us/op 938.00 ns/op 1.21
bytes32 Buffer.toString(hex) + 0x 775.00 ns/op 688.00 ns/op 1.13
Object access 1 prop 0.41300 ns/op 0.37200 ns/op 1.11
Map access 1 prop 0.33100 ns/op 0.29400 ns/op 1.13
Object get x1000 16.656 ns/op 18.304 ns/op 0.91
Map get x1000 0.96900 ns/op 0.96900 ns/op 1.00
Object set x1000 120.42 ns/op 124.66 ns/op 0.97
Map set x1000 78.558 ns/op 76.893 ns/op 1.02
Return object 10000 times 0.42820 ns/op 0.37610 ns/op 1.14
Throw Error 10000 times 8.4614 us/op 6.0132 us/op 1.41
enrSubnets - fastDeserialize 64 bits 3.4070 us/op 2.5210 us/op 1.35
enrSubnets - ssz BitVector 64 bits 906.00 ns/op 755.00 ns/op 1.20
enrSubnets - fastDeserialize 4 bits 520.00 ns/op 369.00 ns/op 1.41
enrSubnets - ssz BitVector 4 bits 918.00 ns/op 734.00 ns/op 1.25
prioritizePeers score -10:0 att 32-0.1 sync 2-0 119.50 us/op 102.61 us/op 1.16
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 151.36 us/op 122.17 us/op 1.24
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 285.11 us/op 221.06 us/op 1.29
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 629.22 us/op 465.52 us/op 1.35
prioritizePeers score 0:0 att 64-1 sync 4-1 581.70 us/op 458.69 us/op 1.27
RateTracker 1000000 limit, 1 obj count per request 214.96 ns/op 188.12 ns/op 1.14
RateTracker 1000000 limit, 2 obj count per request 166.13 ns/op 141.30 ns/op 1.18
RateTracker 1000000 limit, 4 obj count per request 130.69 ns/op 119.87 ns/op 1.09
RateTracker 1000000 limit, 8 obj count per request 126.61 ns/op 107.59 ns/op 1.18
RateTracker with prune 5.4010 us/op 4.2310 us/op 1.28
array of 16000 items push then shift 5.2965 us/op 3.1753 us/op 1.67
LinkedList of 16000 items push then shift 20.406 ns/op 17.525 ns/op 1.16
array of 16000 items push then pop 267.64 ns/op 226.65 ns/op 1.18
LinkedList of 16000 items push then pop 18.485 ns/op 16.272 ns/op 1.14
array of 24000 items push then shift 7.6987 us/op 4.5630 us/op 1.69
LinkedList of 24000 items push then shift 20.899 ns/op 20.273 ns/op 1.03
array of 24000 items push then pop 238.41 ns/op 207.71 ns/op 1.15
LinkedList of 24000 items push then pop 18.768 ns/op 17.661 ns/op 1.06
intersect bitArray bitLen 8 12.059 ns/op 11.701 ns/op 1.03
intersect array and set length 8 201.23 ns/op 167.61 ns/op 1.20
intersect bitArray bitLen 128 70.809 ns/op 72.214 ns/op 0.98
intersect array and set length 128 2.3732 us/op 2.3105 us/op 1.03
Buffer.concat 32 items 2.3600 ns/op 1.9000 ns/op 1.24
pass gossip attestations to forkchoice per slot 4.0067 ms/op 3.2191 ms/op 1.24
computeDeltas 3.5549 ms/op 3.4919 ms/op 1.02
computeProposerBoostScoreFromBalances 879.18 us/op 907.70 us/op 0.97
altair processAttestation - 250000 vs - 7PWei normalcase 5.3332 ms/op 3.7169 ms/op 1.43
altair processAttestation - 250000 vs - 7PWei worstcase 7.5830 ms/op 6.0288 ms/op 1.26
altair processAttestation - setStatus - 1/6 committees join 257.60 us/op 210.30 us/op 1.22
altair processAttestation - setStatus - 1/3 committees join 486.28 us/op 401.52 us/op 1.21
altair processAttestation - setStatus - 1/2 committees join 707.13 us/op 564.88 us/op 1.25
altair processAttestation - setStatus - 2/3 committees join 927.71 us/op 724.12 us/op 1.28
altair processAttestation - setStatus - 4/5 committees join 1.3271 ms/op 1.0049 ms/op 1.32
altair processAttestation - setStatus - 100% committees join 1.5983 ms/op 1.1863 ms/op 1.35
altair processBlock - 250000 vs - 7PWei normalcase 32.615 ms/op 27.418 ms/op 1.19
altair processBlock - 250000 vs - 7PWei normalcase hashState 46.568 ms/op 41.681 ms/op 1.12
altair processBlock - 250000 vs - 7PWei worstcase 107.93 ms/op 83.294 ms/op 1.30
altair processBlock - 250000 vs - 7PWei worstcase hashState 120.44 ms/op 102.47 ms/op 1.18
phase0 processBlock - 250000 vs - 7PWei normalcase 4.4835 ms/op 4.2389 ms/op 1.06
phase0 processBlock - 250000 vs - 7PWei worstcase 54.996 ms/op 49.719 ms/op 1.11
altair processEth1Data - 250000 vs - 7PWei normalcase 1.0746 ms/op 785.28 us/op 1.37
Tree 40 250000 create 979.02 ms/op 832.01 ms/op 1.18
Tree 40 250000 get(125000) 316.43 ns/op 293.04 ns/op 1.08
Tree 40 250000 set(125000) 3.1206 us/op 2.7545 us/op 1.13
Tree 40 250000 toArray() 36.732 ms/op 31.709 ms/op 1.16
Tree 40 250000 iterate all - toArray() + loop 37.737 ms/op 32.270 ms/op 1.17
Tree 40 250000 iterate all - get(i) 133.60 ms/op 111.25 ms/op 1.20
MutableVector 250000 create 18.098 ms/op 15.306 ms/op 1.18
MutableVector 250000 get(125000) 13.975 ns/op 13.087 ns/op 1.07
MutableVector 250000 set(125000) 919.72 ns/op 677.61 ns/op 1.36
MutableVector 250000 toArray() 8.0308 ms/op 12.219 ms/op 0.66
MutableVector 250000 iterate all - toArray() + loop 8.0184 ms/op 7.3261 ms/op 1.09
MutableVector 250000 iterate all - get(i) 3.3666 ms/op 3.2897 ms/op 1.02
Array 250000 create 7.1665 ms/op 6.6140 ms/op 1.08
Array 250000 clone - spread 4.2881 ms/op 2.9964 ms/op 1.43
Array 250000 get(125000) 1.8690 ns/op 1.2740 ns/op 1.47
Array 250000 set(125000) 1.8430 ns/op 1.2580 ns/op 1.47
Array 250000 iterate all - loop 144.72 us/op 167.90 us/op 0.86
effectiveBalanceIncrements clone Uint8Array 300000 228.79 us/op 83.439 us/op 2.74
effectiveBalanceIncrements clone MutableVector 300000 809.00 ns/op 867.00 ns/op 0.93
effectiveBalanceIncrements rw all Uint8Array 300000 286.81 us/op 252.70 us/op 1.13
effectiveBalanceIncrements rw all MutableVector 300000 207.80 ms/op 187.73 ms/op 1.11
phase0 afterProcessEpoch - 250000 vs - 7PWei 217.24 ms/op 181.18 ms/op 1.20
phase0 beforeProcessEpoch - 250000 vs - 7PWei 79.504 ms/op 73.975 ms/op 1.07
altair processEpoch - mainnet_e81889 654.74 ms/op 579.52 ms/op 1.13
mainnet_e81889 - altair beforeProcessEpoch 159.69 ms/op 146.95 ms/op 1.09
mainnet_e81889 - altair processJustificationAndFinalization 71.608 us/op 22.221 us/op 3.22
mainnet_e81889 - altair processInactivityUpdates 11.652 ms/op 10.915 ms/op 1.07
mainnet_e81889 - altair processRewardsAndPenalties 103.47 ms/op 91.927 ms/op 1.13
mainnet_e81889 - altair processRegistryUpdates 14.903 us/op 3.5930 us/op 4.15
mainnet_e81889 - altair processSlashings 3.9010 us/op 836.00 ns/op 4.67
mainnet_e81889 - altair processEth1DataReset 4.3300 us/op 811.00 ns/op 5.34
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.9302 ms/op 2.4175 ms/op 1.21
mainnet_e81889 - altair processSlashingsReset 26.890 us/op 6.4370 us/op 4.18
mainnet_e81889 - altair processRandaoMixesReset 25.372 us/op 5.2830 us/op 4.80
mainnet_e81889 - altair processHistoricalRootsUpdate 4.3220 us/op 813.00 ns/op 5.32
mainnet_e81889 - altair processParticipationFlagUpdates 15.878 us/op 2.8110 us/op 5.65
mainnet_e81889 - altair processSyncCommitteeUpdates 3.2590 us/op 667.00 ns/op 4.89
mainnet_e81889 - altair afterProcessEpoch 211.84 ms/op 192.57 ms/op 1.10
phase0 processEpoch - mainnet_e58758 624.90 ms/op 525.91 ms/op 1.19
mainnet_e58758 - phase0 beforeProcessEpoch 275.10 ms/op 232.53 ms/op 1.18
mainnet_e58758 - phase0 processJustificationAndFinalization 65.212 us/op 20.413 us/op 3.19
mainnet_e58758 - phase0 processRewardsAndPenalties 158.25 ms/op 142.73 ms/op 1.11
mainnet_e58758 - phase0 processRegistryUpdates 33.433 us/op 9.8530 us/op 3.39
mainnet_e58758 - phase0 processSlashings 3.4800 us/op 742.00 ns/op 4.69
mainnet_e58758 - phase0 processEth1DataReset 3.6140 us/op 769.00 ns/op 4.70
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.6162 ms/op 1.8919 ms/op 1.38
mainnet_e58758 - phase0 processSlashingsReset 17.713 us/op 4.0550 us/op 4.37
mainnet_e58758 - phase0 processRandaoMixesReset 26.512 us/op 5.5470 us/op 4.78
mainnet_e58758 - phase0 processHistoricalRootsUpdate 4.4650 us/op 785.00 ns/op 5.69
mainnet_e58758 - phase0 processParticipationRecordUpdates 24.311 us/op 4.6580 us/op 5.22
mainnet_e58758 - phase0 afterProcessEpoch 167.61 ms/op 157.70 ms/op 1.06
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.4715 ms/op 2.6287 ms/op 0.94
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.2964 ms/op 3.4319 ms/op 0.96
altair processInactivityUpdates - 250000 normalcase 48.137 ms/op 39.288 ms/op 1.23
altair processInactivityUpdates - 250000 worstcase 57.367 ms/op 51.049 ms/op 1.12
phase0 processRegistryUpdates - 250000 normalcase 29.080 us/op 8.2250 us/op 3.54
phase0 processRegistryUpdates - 250000 badcase_full_deposits 529.45 us/op 407.43 us/op 1.30
phase0 processRegistryUpdates - 250000 worstcase 0.5 244.28 ms/op 210.32 ms/op 1.16
altair processRewardsAndPenalties - 250000 normalcase 170.55 ms/op 125.82 ms/op 1.36
altair processRewardsAndPenalties - 250000 worstcase 98.145 ms/op 87.301 ms/op 1.12
phase0 getAttestationDeltas - 250000 normalcase 15.752 ms/op 13.533 ms/op 1.16
phase0 getAttestationDeltas - 250000 worstcase 15.428 ms/op 13.671 ms/op 1.13
phase0 processSlashings - 250000 worstcase 6.3978 ms/op 5.3569 ms/op 1.19
altair processSyncCommitteeUpdates - 250000 350.42 ms/op 285.64 ms/op 1.23
BeaconState.hashTreeRoot - No change 594.00 ns/op 499.00 ns/op 1.19
BeaconState.hashTreeRoot - 1 full validator 80.740 us/op 55.522 us/op 1.45
BeaconState.hashTreeRoot - 32 full validator 809.07 us/op 551.17 us/op 1.47
BeaconState.hashTreeRoot - 512 full validator 9.9905 ms/op 6.1534 ms/op 1.62
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 101.54 us/op 81.865 us/op 1.24
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.4494 ms/op 1.2068 ms/op 1.20
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 19.494 ms/op 18.212 ms/op 1.07
BeaconState.hashTreeRoot - 1 balances 75.006 us/op 61.527 us/op 1.22
BeaconState.hashTreeRoot - 32 balances 712.49 us/op 563.24 us/op 1.26
BeaconState.hashTreeRoot - 512 balances 7.0678 ms/op 5.6544 ms/op 1.25
BeaconState.hashTreeRoot - 250000 balances 108.35 ms/op 94.456 ms/op 1.15
aggregationBits - 2048 els - zipIndexesInBitList 38.752 us/op 35.729 us/op 1.08
regular array get 100000 times 58.151 us/op 67.408 us/op 0.86
wrappedArray get 100000 times 56.336 us/op 67.406 us/op 0.84
arrayWithProxy get 100000 times 34.019 ms/op 28.908 ms/op 1.18
ssz.Root.equals 598.00 ns/op 504.00 ns/op 1.19
byteArrayEquals 595.00 ns/op 516.00 ns/op 1.15
shuffle list - 16384 els 12.549 ms/op 11.084 ms/op 1.13
shuffle list - 250000 els 172.82 ms/op 163.43 ms/op 1.06
processSlot - 1 slots 17.194 us/op 12.744 us/op 1.35
processSlot - 32 slots 2.1906 ms/op 1.8340 ms/op 1.19
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 541.75 us/op 351.95 us/op 1.54
getCommitteeAssignments - req 1 vs - 250000 vc 5.1282 ms/op 5.2780 ms/op 0.97
getCommitteeAssignments - req 100 vs - 250000 vc 7.6307 ms/op 7.3379 ms/op 1.04
getCommitteeAssignments - req 1000 vs - 250000 vc 8.3935 ms/op 7.7631 ms/op 1.08
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 9.6800 ns/op 9.5900 ns/op 1.01
state getBlockRootAtSlot - 250000 vs - 7PWei 1.4705 us/op 1.2234 us/op 1.20
computeProposers - vc 250000 19.457 ms/op 16.999 ms/op 1.14
computeEpochShuffling - vc 250000 176.73 ms/op 165.61 ms/op 1.07
getNextSyncCommittee - vc 250000 328.51 ms/op 281.01 ms/op 1.17

by benchmarkbot/action

@g11tech g11tech merged commit 43f7ba0 into unstable Sep 11, 2022
@g11tech g11tech deleted the g11tech/default-log branch September 11, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable LogFile by default at dataDir
2 participants