Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up cli logger args #4538

Merged
merged 3 commits into from Sep 13, 2022
Merged

Clean up cli logger args #4538

merged 3 commits into from Sep 13, 2022

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Sep 12, 2022 •
edited

Motivation

Description

  • De-duplicate logic to disable logFile
  • Move logFile option into logger options (do path manipulation outside of getXYZPaths)
  • Move logger options to its own file. Now used by beacon validator and lightclient cmds
  • Re-use validator.log file for slashing import export cmds
  • Remove need to pass logger to LevelDbController

@dapplion dapplion requested a review from a team as a code owner September 12, 2022 16:00
@dapplion dapplion force-pushed the dapplion/log-file-args-cleanup branch from b5882f0 to eb26240 Compare September 12, 2022 16:15
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2022 •
edited

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 491aea0 Previous: 2c41af0 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.4174 ms/op 2.3797 ms/op 1.02
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 90.585 us/op 81.078 us/op 1.12
BLS verify - blst-native 2.2204 ms/op 1.8628 ms/op 1.19
BLS verifyMultipleSignatures 3 - blst-native 4.5686 ms/op 3.8196 ms/op 1.20
BLS verifyMultipleSignatures 8 - blst-native 9.7972 ms/op 8.2347 ms/op 1.19
BLS verifyMultipleSignatures 32 - blst-native 35.543 ms/op 29.812 ms/op 1.19
BLS aggregatePubkeys 32 - blst-native 47.011 us/op 39.224 us/op 1.20
BLS aggregatePubkeys 128 - blst-native 182.40 us/op 153.42 us/op 1.19
getAttestationsForBlock 206.56 ms/op 172.54 ms/op 1.20
isKnown best case - 1 super set check 516.00 ns/op 432.00 ns/op 1.19
isKnown normal case - 2 super set checks 497.00 ns/op 425.00 ns/op 1.17
isKnown worse case - 16 super set checks 502.00 ns/op 425.00 ns/op 1.18
CheckpointStateCache - add get delete 10.520 us/op 9.2060 us/op 1.14
validate gossip signedAggregateAndProof - struct 5.1070 ms/op 4.2854 ms/op 1.19
validate gossip attestation - struct 2.4356 ms/op 2.0418 ms/op 1.19
pickEth1Vote - no votes 2.5615 ms/op 2.2155 ms/op 1.16
pickEth1Vote - max votes 23.460 ms/op 21.583 ms/op 1.09
pickEth1Vote - Eth1Data hashTreeRoot value x2048 13.516 ms/op 11.441 ms/op 1.18
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 25.638 ms/op 20.703 ms/op 1.24
pickEth1Vote - Eth1Data fastSerialize value x2048 1.7988 ms/op 1.5559 ms/op 1.16
pickEth1Vote - Eth1Data fastSerialize tree x2048 15.971 ms/op 14.007 ms/op 1.14
bytes32 toHexString 1.2530 us/op 1.1510 us/op 1.09
bytes32 Buffer.toString(hex) 873.00 ns/op 713.00 ns/op 1.22
bytes32 Buffer.toString(hex) from Uint8Array 1.1710 us/op 1.0150 us/op 1.15
bytes32 Buffer.toString(hex) + 0x 856.00 ns/op 720.00 ns/op 1.19
Object access 1 prop 0.45300 ns/op 0.39100 ns/op 1.16
Map access 1 prop 0.34800 ns/op 0.29600 ns/op 1.18
Object get x1000 21.575 ns/op 17.714 ns/op 1.22
Map get x1000 1.2180 ns/op 1.0070 ns/op 1.21
Object set x1000 140.97 ns/op 125.56 ns/op 1.12
Map set x1000 86.539 ns/op 76.322 ns/op 1.13
Return object 10000 times 0.44820 ns/op 0.36700 ns/op 1.22
Throw Error 10000 times 7.2124 us/op 5.9994 us/op 1.20
enrSubnets - fastDeserialize 64 bits 3.3340 us/op 2.9050 us/op 1.15
enrSubnets - ssz BitVector 64 bits 937.00 ns/op 837.00 ns/op 1.12
enrSubnets - fastDeserialize 4 bits 491.00 ns/op 425.00 ns/op 1.16
enrSubnets - ssz BitVector 4 bits 926.00 ns/op 831.00 ns/op 1.11
prioritizePeers score -10:0 att 32-0.1 sync 2-0 116.97 us/op 97.933 us/op 1.19
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 146.08 us/op 137.65 us/op 1.06
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 261.74 us/op 245.07 us/op 1.07
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 555.15 us/op 394.47 us/op 1.41
prioritizePeers score 0:0 att 64-1 sync 4-1 548.79 us/op 462.51 us/op 1.19
RateTracker 1000000 limit, 1 obj count per request 243.88 ns/op 208.65 ns/op 1.17
RateTracker 1000000 limit, 2 obj count per request 180.45 ns/op 163.05 ns/op 1.11
RateTracker 1000000 limit, 4 obj count per request 151.70 ns/op 140.07 ns/op 1.08
RateTracker 1000000 limit, 8 obj count per request 132.45 ns/op 128.38 ns/op 1.03
RateTracker with prune 5.3560 us/op 5.5300 us/op 0.97
array of 16000 items push then shift 3.7891 us/op 3.2029 us/op 1.18
LinkedList of 16000 items push then shift 20.366 ns/op 17.924 ns/op 1.14
array of 16000 items push then pop 267.07 ns/op 248.41 ns/op 1.08
LinkedList of 16000 items push then pop 19.142 ns/op 16.821 ns/op 1.14
array of 24000 items push then shift 5.4643 us/op 4.5949 us/op 1.19
LinkedList of 24000 items push then shift 24.012 ns/op 21.604 ns/op 1.11
array of 24000 items push then pop 249.35 ns/op 218.46 ns/op 1.14
LinkedList of 24000 items push then pop 20.535 ns/op 18.396 ns/op 1.12
intersect bitArray bitLen 8 14.136 ns/op 11.790 ns/op 1.20
intersect array and set length 8 197.64 ns/op 186.17 ns/op 1.06
intersect bitArray bitLen 128 74.672 ns/op 62.037 ns/op 1.20
intersect array and set length 128 2.7587 us/op 2.3487 us/op 1.17
Buffer.concat 32 items 2.6410 ns/op 2.2660 ns/op 1.17
pass gossip attestations to forkchoice per slot 5.0965 ms/op 5.9424 ms/op 0.86
computeDeltas 4.1751 ms/op 3.6793 ms/op 1.13
computeProposerBoostScoreFromBalances 1.1025 ms/op 909.54 us/op 1.21
altair processAttestation - 250000 vs - 7PWei normalcase 4.6060 ms/op 4.0715 ms/op 1.13
altair processAttestation - 250000 vs - 7PWei worstcase 7.5325 ms/op 6.1415 ms/op 1.23
altair processAttestation - setStatus - 1/6 committees join 241.15 us/op 218.69 us/op 1.10
altair processAttestation - setStatus - 1/3 committees join 471.93 us/op 417.39 us/op 1.13
altair processAttestation - setStatus - 1/2 committees join 659.47 us/op 584.18 us/op 1.13
altair processAttestation - setStatus - 2/3 committees join 846.51 us/op 755.31 us/op 1.12
altair processAttestation - setStatus - 4/5 committees join 1.1800 ms/op 1.0357 ms/op 1.14
altair processAttestation - setStatus - 100% committees join 1.3850 ms/op 1.2215 ms/op 1.13
altair processBlock - 250000 vs - 7PWei normalcase 32.250 ms/op 28.393 ms/op 1.14
altair processBlock - 250000 vs - 7PWei normalcase hashState 49.804 ms/op 39.125 ms/op 1.27
altair processBlock - 250000 vs - 7PWei worstcase 96.818 ms/op 74.938 ms/op 1.29
altair processBlock - 250000 vs - 7PWei worstcase hashState 117.14 ms/op 97.574 ms/op 1.20
phase0 processBlock - 250000 vs - 7PWei normalcase 4.4361 ms/op 3.8407 ms/op 1.16
phase0 processBlock - 250000 vs - 7PWei worstcase 56.007 ms/op 46.765 ms/op 1.20
altair processEth1Data - 250000 vs - 7PWei normalcase 1.1566 ms/op 901.51 us/op 1.28
Tree 40 250000 create 970.40 ms/op 889.76 ms/op 1.09
Tree 40 250000 get(125000) 372.88 ns/op 288.11 ns/op 1.29
Tree 40 250000 set(125000) 3.9529 us/op 2.5491 us/op 1.55
Tree 40 250000 toArray() 38.610 ms/op 31.810 ms/op 1.21
Tree 40 250000 iterate all - toArray() + loop 38.706 ms/op 31.521 ms/op 1.23
Tree 40 250000 iterate all - get(i) 134.37 ms/op 109.22 ms/op 1.23
MutableVector 250000 create 20.644 ms/op 18.384 ms/op 1.12
MutableVector 250000 get(125000) 15.940 ns/op 13.128 ns/op 1.21
MutableVector 250000 set(125000) 911.95 ns/op 681.94 ns/op 1.34
MutableVector 250000 toArray() 9.1026 ms/op 7.7551 ms/op 1.17
MutableVector 250000 iterate all - toArray() + loop 9.6478 ms/op 7.8476 ms/op 1.23
MutableVector 250000 iterate all - get(i) 4.1250 ms/op 3.4454 ms/op 1.20
Array 250000 create 7.8468 ms/op 7.1051 ms/op 1.10
Array 250000 clone - spread 3.2154 ms/op 4.1611 ms/op 0.77
Array 250000 get(125000) 1.3760 ns/op 1.7090 ns/op 0.81
Array 250000 set(125000) 1.3510 ns/op 1.7040 ns/op 0.79
Array 250000 iterate all - loop 201.48 us/op 168.20 us/op 1.20
effectiveBalanceIncrements clone Uint8Array 300000 89.758 us/op 98.529 us/op 0.91
effectiveBalanceIncrements clone MutableVector 300000 901.00 ns/op 1.3240 us/op 0.68
effectiveBalanceIncrements rw all Uint8Array 300000 303.34 us/op 253.54 us/op 1.20
effectiveBalanceIncrements rw all MutableVector 300000 201.51 ms/op 227.49 ms/op 0.89
phase0 afterProcessEpoch - 250000 vs - 7PWei 225.34 ms/op 187.19 ms/op 1.20
phase0 beforeProcessEpoch - 250000 vs - 7PWei 81.839 ms/op 92.531 ms/op 0.88
altair processEpoch - mainnet_e81889 677.40 ms/op 581.79 ms/op 1.16
mainnet_e81889 - altair beforeProcessEpoch 184.12 ms/op 157.89 ms/op 1.17
mainnet_e81889 - altair processJustificationAndFinalization 36.320 us/op 23.341 us/op 1.56
mainnet_e81889 - altair processInactivityUpdates 12.685 ms/op 10.953 ms/op 1.16
mainnet_e81889 - altair processRewardsAndPenalties 108.28 ms/op 91.080 ms/op 1.19
mainnet_e81889 - altair processRegistryUpdates 7.0620 us/op 3.7610 us/op 1.88
mainnet_e81889 - altair processSlashings 1.5490 us/op 912.00 ns/op 1.70
mainnet_e81889 - altair processEth1DataReset 1.7270 us/op 894.00 ns/op 1.93
mainnet_e81889 - altair processEffectiveBalanceUpdates 3.0117 ms/op 2.2426 ms/op 1.34
mainnet_e81889 - altair processSlashingsReset 13.685 us/op 5.5600 us/op 2.46
mainnet_e81889 - altair processRandaoMixesReset 12.127 us/op 6.1910 us/op 1.96
mainnet_e81889 - altair processHistoricalRootsUpdate 1.7030 us/op 990.00 ns/op 1.72
mainnet_e81889 - altair processParticipationFlagUpdates 5.9440 us/op 2.8940 us/op 2.05
mainnet_e81889 - altair processSyncCommitteeUpdates 1.5560 us/op 784.00 ns/op 1.98
mainnet_e81889 - altair afterProcessEpoch 234.79 ms/op 195.52 ms/op 1.20
phase0 processEpoch - mainnet_e58758 665.49 ms/op 523.30 ms/op 1.27
mainnet_e58758 - phase0 beforeProcessEpoch 276.34 ms/op 227.93 ms/op 1.21
mainnet_e58758 - phase0 processJustificationAndFinalization 36.654 us/op 20.585 us/op 1.78
mainnet_e58758 - phase0 processRewardsAndPenalties 171.98 ms/op 82.798 ms/op 2.08
mainnet_e58758 - phase0 processRegistryUpdates 17.959 us/op 10.806 us/op 1.66
mainnet_e58758 - phase0 processSlashings 1.7600 us/op 816.00 ns/op 2.16
mainnet_e58758 - phase0 processEth1DataReset 1.7430 us/op 866.00 ns/op 2.01
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.8845 ms/op 1.9929 ms/op 1.45
mainnet_e58758 - phase0 processSlashingsReset 8.9170 us/op 5.0650 us/op 1.76
mainnet_e58758 - phase0 processRandaoMixesReset 12.941 us/op 6.1660 us/op 2.10
mainnet_e58758 - phase0 processHistoricalRootsUpdate 2.2760 us/op 900.00 ns/op 2.53
mainnet_e58758 - phase0 processParticipationRecordUpdates 13.837 us/op 4.8190 us/op 2.87
mainnet_e58758 - phase0 afterProcessEpoch 200.38 ms/op 162.00 ms/op 1.24
phase0 processEffectiveBalanceUpdates - 250000 normalcase 3.1482 ms/op 2.5481 ms/op 1.24
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 4.1822 ms/op 3.4662 ms/op 1.21
altair processInactivityUpdates - 250000 normalcase 50.223 ms/op 39.955 ms/op 1.26
altair processInactivityUpdates - 250000 worstcase 61.320 ms/op 40.929 ms/op 1.50
phase0 processRegistryUpdates - 250000 normalcase 16.122 us/op 8.3850 us/op 1.92
phase0 processRegistryUpdates - 250000 badcase_full_deposits 500.37 us/op 414.60 us/op 1.21
phase0 processRegistryUpdates - 250000 worstcase 0.5 260.82 ms/op 215.11 ms/op 1.21
altair processRewardsAndPenalties - 250000 normalcase 156.66 ms/op 82.468 ms/op 1.90
altair processRewardsAndPenalties - 250000 worstcase 101.01 ms/op 132.66 ms/op 0.76
phase0 getAttestationDeltas - 250000 normalcase 16.366 ms/op 13.620 ms/op 1.20
phase0 getAttestationDeltas - 250000 worstcase 16.209 ms/op 13.198 ms/op 1.23
phase0 processSlashings - 250000 worstcase 6.3518 ms/op 5.3612 ms/op 1.18
altair processSyncCommitteeUpdates - 250000 347.15 ms/op 282.17 ms/op 1.23
BeaconState.hashTreeRoot - No change 587.00 ns/op 509.00 ns/op 1.15
BeaconState.hashTreeRoot - 1 full validator 72.717 us/op 64.633 us/op 1.13
BeaconState.hashTreeRoot - 32 full validator 743.31 us/op 655.33 us/op 1.13
BeaconState.hashTreeRoot - 512 full validator 9.2997 ms/op 6.0366 ms/op 1.54
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 99.535 us/op 78.224 us/op 1.27
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.4206 ms/op 1.1801 ms/op 1.20
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 20.190 ms/op 15.933 ms/op 1.27
BeaconState.hashTreeRoot - 1 balances 75.543 us/op 61.275 us/op 1.23
BeaconState.hashTreeRoot - 32 balances 695.94 us/op 650.18 us/op 1.07
BeaconState.hashTreeRoot - 512 balances 6.9506 ms/op 5.6185 ms/op 1.24
BeaconState.hashTreeRoot - 250000 balances 116.05 ms/op 94.720 ms/op 1.23
aggregationBits - 2048 els - zipIndexesInBitList 36.976 us/op 33.582 us/op 1.10
regular array get 100000 times 80.911 us/op 67.637 us/op 1.20
wrappedArray get 100000 times 80.966 us/op 67.673 us/op 1.20
arrayWithProxy get 100000 times 34.885 ms/op 29.495 ms/op 1.18
ssz.Root.equals 583.00 ns/op 499.00 ns/op 1.17
byteArrayEquals 576.00 ns/op 491.00 ns/op 1.17
shuffle list - 16384 els 13.518 ms/op 11.285 ms/op 1.20
shuffle list - 250000 els 197.73 ms/op 165.36 ms/op 1.20
processSlot - 1 slots 15.511 us/op 11.961 us/op 1.30
processSlot - 32 slots 2.1863 ms/op 1.8149 ms/op 1.20
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 1.5557 ms/op 354.83 us/op 4.38
getCommitteeAssignments - req 1 vs - 250000 vc 6.3790 ms/op 5.3330 ms/op 1.20
getCommitteeAssignments - req 100 vs - 250000 vc 8.7766 ms/op 7.2957 ms/op 1.20
getCommitteeAssignments - req 1000 vs - 250000 vc 9.3948 ms/op 7.7438 ms/op 1.21
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 12.900 ns/op 9.4100 ns/op 1.37
state getBlockRootAtSlot - 250000 vs - 7PWei 1.4988 us/op 1.2265 us/op 1.22
computeProposers - vc 250000 19.844 ms/op 17.405 ms/op 1.14
computeEpochShuffling - vc 250000 202.98 ms/op 168.17 ms/op 1.21
getNextSyncCommittee - vc 250000 331.70 ms/op 281.24 ms/op 1.18

by benchmarkbot/action

g11tech
g11tech approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome! much cleaner

@g11tech g11tech enabled auto-merge (squash) September 13, 2022 07:43
@g11tech g11tech merged commit a5bf126 into unstable Sep 13, 2022
@g11tech g11tech deleted the dapplion/log-file-args-cleanup branch September 13, 2022 07:46
@dapplion dapplion mentioned this pull request Sep 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dapplion @g11tech