Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip signValidatorRegistration test #4644

Merged
merged 1 commit into from Oct 5, 2022

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Oct 5, 2022

Motivation

Non-deterministic test, broke CI here https://github.com/ChainSafe/lodestar/actions/runs/3188628194/jobs/5201508967

Description

  • Skip signValidatorRegistration test

@dapplion dapplion requested a review from a team as a code owner October 5, 2022 10:00
@dapplion dapplion enabled auto-merge (squash) October 5, 2022 10:00
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 5f247ec Previous: 68f34f4 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.4468 ms/op 1.8697 ms/op 1.31
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 85.509 us/op 64.716 us/op 1.32
BLS verify - blst-native 2.2054 ms/op 2.1743 ms/op 1.01
BLS verifyMultipleSignatures 3 - blst-native 4.2795 ms/op 4.4710 ms/op 0.96
BLS verifyMultipleSignatures 8 - blst-native 9.7611 ms/op 9.6741 ms/op 1.01
BLS verifyMultipleSignatures 32 - blst-native 33.100 ms/op 35.156 ms/op 0.94
BLS aggregatePubkeys 32 - blst-native 44.590 us/op 46.683 us/op 0.96
BLS aggregatePubkeys 128 - blst-native 180.08 us/op 182.12 us/op 0.99
getAttestationsForBlock 100.13 ms/op 81.960 ms/op 1.22
isKnown best case - 1 super set check 485.00 ns/op 459.00 ns/op 1.06
isKnown normal case - 2 super set checks 482.00 ns/op 451.00 ns/op 1.07
isKnown worse case - 16 super set checks 496.00 ns/op 449.00 ns/op 1.10
CheckpointStateCache - add get delete 10.066 us/op 8.5950 us/op 1.17
validate gossip signedAggregateAndProof - struct 5.0785 ms/op 5.0110 ms/op 1.01
validate gossip attestation - struct 2.3138 ms/op 2.3794 ms/op 0.97
pickEth1Vote - no votes 2.4907 ms/op 2.2340 ms/op 1.11
pickEth1Vote - max votes 22.672 ms/op 17.775 ms/op 1.28
pickEth1Vote - Eth1Data hashTreeRoot value x2048 12.900 ms/op 12.153 ms/op 1.06
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 23.169 ms/op 19.292 ms/op 1.20
pickEth1Vote - Eth1Data fastSerialize value x2048 1.7575 ms/op 1.4106 ms/op 1.25
pickEth1Vote - Eth1Data fastSerialize tree x2048 15.490 ms/op 11.985 ms/op 1.29
bytes32 toHexString 1.2880 us/op 920.00 ns/op 1.40
bytes32 Buffer.toString(hex) 787.00 ns/op 687.00 ns/op 1.15
bytes32 Buffer.toString(hex) from Uint8Array 1.1210 us/op 990.00 ns/op 1.13
bytes32 Buffer.toString(hex) + 0x 824.00 ns/op 691.00 ns/op 1.19
Object access 1 prop 0.42200 ns/op 0.33400 ns/op 1.26
Map access 1 prop 0.33400 ns/op 0.30500 ns/op 1.10
Object get x1000 21.017 ns/op 11.139 ns/op 1.89
Map get x1000 1.1340 ns/op 0.96000 ns/op 1.18
Object set x1000 138.47 ns/op 69.071 ns/op 2.00
Map set x1000 85.135 ns/op 45.411 ns/op 1.87
Return object 10000 times 0.44460 ns/op 0.43320 ns/op 1.03
Throw Error 10000 times 6.8144 us/op 6.0676 us/op 1.12
enrSubnets - fastDeserialize 64 bits 3.0250 us/op 2.4510 us/op 1.23
enrSubnets - ssz BitVector 64 bits 833.00 ns/op 731.00 ns/op 1.14
enrSubnets - fastDeserialize 4 bits 464.00 ns/op 359.00 ns/op 1.29
enrSubnets - ssz BitVector 4 bits 837.00 ns/op 721.00 ns/op 1.16
prioritizePeers score -10:0 att 32-0.1 sync 2-0 113.22 us/op 80.636 us/op 1.40
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 139.74 us/op 124.15 us/op 1.13
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 260.47 us/op 198.25 us/op 1.31
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 503.52 us/op 335.57 us/op 1.50
prioritizePeers score 0:0 att 64-1 sync 4-1 549.22 us/op 405.49 us/op 1.35
RateTracker 1000000 limit, 1 obj count per request 222.01 ns/op 175.94 ns/op 1.26
RateTracker 1000000 limit, 2 obj count per request 169.10 ns/op 128.98 ns/op 1.31
RateTracker 1000000 limit, 4 obj count per request 141.97 ns/op 105.83 ns/op 1.34
RateTracker 1000000 limit, 8 obj count per request 121.16 ns/op 94.322 ns/op 1.28
RateTracker with prune 4.7350 us/op 3.9200 us/op 1.21
array of 16000 items push then shift 3.7707 us/op 51.576 us/op 0.07
LinkedList of 16000 items push then shift 19.701 ns/op 11.989 ns/op 1.64
array of 16000 items push then pop 266.32 ns/op 194.34 ns/op 1.37
LinkedList of 16000 items push then pop 17.957 ns/op 11.828 ns/op 1.52
array of 24000 items push then shift 5.3587 us/op 77.333 us/op 0.07
LinkedList of 24000 items push then shift 23.487 ns/op 12.368 ns/op 1.90
array of 24000 items push then pop 244.51 ns/op 196.97 ns/op 1.24
LinkedList of 24000 items push then pop 20.965 ns/op 12.068 ns/op 1.74
intersect bitArray bitLen 8 13.919 ns/op 10.929 ns/op 1.27
intersect array and set length 8 185.67 ns/op 134.76 ns/op 1.38
intersect bitArray bitLen 128 84.548 ns/op 57.657 ns/op 1.47
intersect array and set length 128 2.6928 us/op 1.7773 us/op 1.52
Buffer.concat 32 items 2.6840 ns/op 1.7680 ns/op 1.52
pass gossip attestations to forkchoice per slot 4.4475 ms/op 5.5568 ms/op 0.80
computeDeltas 6.2483 ms/op 4.4252 ms/op 1.41
computeProposerBoostScoreFromBalances 1.0914 ms/op 804.31 us/op 1.36
altair processAttestation - 250000 vs - 7PWei normalcase 4.9476 ms/op 3.2491 ms/op 1.52
altair processAttestation - 250000 vs - 7PWei worstcase 7.4978 ms/op 5.0290 ms/op 1.49
altair processAttestation - setStatus - 1/6 committees join 247.81 us/op 181.96 us/op 1.36
altair processAttestation - setStatus - 1/3 committees join 466.55 us/op 359.10 us/op 1.30
altair processAttestation - setStatus - 1/2 committees join 628.48 us/op 513.32 us/op 1.22
altair processAttestation - setStatus - 2/3 committees join 868.88 us/op 684.52 us/op 1.27
altair processAttestation - setStatus - 4/5 committees join 1.1482 ms/op 946.31 us/op 1.21
altair processAttestation - setStatus - 100% committees join 1.4471 ms/op 1.1541 ms/op 1.25
altair processBlock - 250000 vs - 7PWei normalcase 32.099 ms/op 27.417 ms/op 1.17
altair processBlock - 250000 vs - 7PWei normalcase hashState 43.232 ms/op 36.813 ms/op 1.17
altair processBlock - 250000 vs - 7PWei worstcase 98.041 ms/op 80.796 ms/op 1.21
altair processBlock - 250000 vs - 7PWei worstcase hashState 118.88 ms/op 100.85 ms/op 1.18
phase0 processBlock - 250000 vs - 7PWei normalcase 4.2950 ms/op 3.2481 ms/op 1.32
phase0 processBlock - 250000 vs - 7PWei worstcase 56.405 ms/op 51.148 ms/op 1.10
altair processEth1Data - 250000 vs - 7PWei normalcase 1.0403 ms/op 799.45 us/op 1.30
Tree 40 250000 create 932.23 ms/op 710.95 ms/op 1.31
Tree 40 250000 get(125000) 339.59 ns/op 230.61 ns/op 1.47
Tree 40 250000 set(125000) 2.9057 us/op 2.4097 us/op 1.21
Tree 40 250000 toArray() 37.575 ms/op 27.154 ms/op 1.38
Tree 40 250000 iterate all - toArray() + loop 36.908 ms/op 27.394 ms/op 1.35
Tree 40 250000 iterate all - get(i) 129.80 ms/op 107.75 ms/op 1.20
MutableVector 250000 create 18.620 ms/op 14.358 ms/op 1.30
MutableVector 250000 get(125000) 18.521 ns/op 10.907 ns/op 1.70
MutableVector 250000 set(125000) 815.69 ns/op 561.76 ns/op 1.45
MutableVector 250000 toArray() 8.8223 ms/op 6.2127 ms/op 1.42
MutableVector 250000 iterate all - toArray() + loop 9.3024 ms/op 6.2106 ms/op 1.50
MutableVector 250000 iterate all - get(i) 3.9770 ms/op 2.7139 ms/op 1.47
Array 250000 create 8.1570 ms/op 5.8838 ms/op 1.39
Array 250000 clone - spread 4.9929 ms/op 3.5317 ms/op 1.41
Array 250000 get(125000) 2.0420 ns/op 1.6160 ns/op 1.26
Array 250000 set(125000) 2.0570 ns/op 1.5990 ns/op 1.29
Array 250000 iterate all - loop 199.46 us/op 151.09 us/op 1.32
effectiveBalanceIncrements clone Uint8Array 300000 101.70 us/op 48.914 us/op 2.08
effectiveBalanceIncrements clone MutableVector 300000 776.00 ns/op 1.1540 us/op 0.67
effectiveBalanceIncrements rw all Uint8Array 300000 285.56 us/op 247.21 us/op 1.16
effectiveBalanceIncrements rw all MutableVector 300000 187.68 ms/op 177.98 ms/op 1.05
phase0 afterProcessEpoch - 250000 vs - 7PWei 212.08 ms/op 184.82 ms/op 1.15
phase0 beforeProcessEpoch - 250000 vs - 7PWei 76.221 ms/op 58.369 ms/op 1.31
altair processEpoch - mainnet_e81889 666.06 ms/op 541.45 ms/op 1.23
mainnet_e81889 - altair beforeProcessEpoch 194.98 ms/op 122.05 ms/op 1.60
mainnet_e81889 - altair processJustificationAndFinalization 38.179 us/op 24.386 us/op 1.57
mainnet_e81889 - altair processInactivityUpdates 12.022 ms/op 8.7238 ms/op 1.38
mainnet_e81889 - altair processRewardsAndPenalties 104.21 ms/op 116.01 ms/op 0.90
mainnet_e81889 - altair processRegistryUpdates 7.6360 us/op 3.8270 us/op 2.00
mainnet_e81889 - altair processSlashings 2.0590 us/op 804.00 ns/op 2.56
mainnet_e81889 - altair processEth1DataReset 1.9290 us/op 998.00 ns/op 1.93
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.7665 ms/op 2.2556 ms/op 1.23
mainnet_e81889 - altair processSlashingsReset 11.989 us/op 6.1690 us/op 1.94
mainnet_e81889 - altair processRandaoMixesReset 13.266 us/op 5.4830 us/op 2.42
mainnet_e81889 - altair processHistoricalRootsUpdate 2.4030 us/op 1.0890 us/op 2.21
mainnet_e81889 - altair processParticipationFlagUpdates 10.722 us/op 2.7960 us/op 3.83
mainnet_e81889 - altair processSyncCommitteeUpdates 1.9730 us/op 959.00 ns/op 2.06
mainnet_e81889 - altair afterProcessEpoch 224.02 ms/op 194.95 ms/op 1.15
phase0 processEpoch - mainnet_e58758 610.06 ms/op 480.83 ms/op 1.27
mainnet_e58758 - phase0 beforeProcessEpoch 293.74 ms/op 178.66 ms/op 1.64
mainnet_e58758 - phase0 processJustificationAndFinalization 31.340 us/op 16.871 us/op 1.86
mainnet_e58758 - phase0 processRewardsAndPenalties 92.199 ms/op 72.179 ms/op 1.28
mainnet_e58758 - phase0 processRegistryUpdates 17.253 us/op 9.4750 us/op 1.82
mainnet_e58758 - phase0 processSlashings 2.0200 us/op 762.00 ns/op 2.65
mainnet_e58758 - phase0 processEth1DataReset 1.7890 us/op 787.00 ns/op 2.27
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.7490 ms/op 1.8096 ms/op 1.52
mainnet_e58758 - phase0 processSlashingsReset 9.5660 us/op 3.9070 us/op 2.45
mainnet_e58758 - phase0 processRandaoMixesReset 13.882 us/op 3.9220 us/op 3.54
mainnet_e58758 - phase0 processHistoricalRootsUpdate 2.0050 us/op 936.00 ns/op 2.14
mainnet_e58758 - phase0 processParticipationRecordUpdates 10.122 us/op 4.5670 us/op 2.22
mainnet_e58758 - phase0 afterProcessEpoch 188.80 ms/op 166.84 ms/op 1.13
phase0 processEffectiveBalanceUpdates - 250000 normalcase 3.2088 ms/op 2.0723 ms/op 1.55
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 4.7071 ms/op 2.3142 ms/op 2.03
altair processInactivityUpdates - 250000 normalcase 49.497 ms/op 40.532 ms/op 1.22
altair processInactivityUpdates - 250000 worstcase 47.569 ms/op 32.809 ms/op 1.45
phase0 processRegistryUpdates - 250000 normalcase 15.496 us/op 9.5060 us/op 1.63
phase0 processRegistryUpdates - 250000 badcase_full_deposits 539.78 us/op 446.19 us/op 1.21
phase0 processRegistryUpdates - 250000 worstcase 0.5 257.93 ms/op 166.69 ms/op 1.55
altair processRewardsAndPenalties - 250000 normalcase 151.80 ms/op 76.471 ms/op 1.99
altair processRewardsAndPenalties - 250000 worstcase 103.85 ms/op 98.112 ms/op 1.06
phase0 getAttestationDeltas - 250000 normalcase 14.828 ms/op 10.552 ms/op 1.41
phase0 getAttestationDeltas - 250000 worstcase 15.620 ms/op 11.468 ms/op 1.36
phase0 processSlashings - 250000 worstcase 6.4487 ms/op 5.0224 ms/op 1.28
altair processSyncCommitteeUpdates - 250000 343.69 ms/op 288.17 ms/op 1.19
BeaconState.hashTreeRoot - No change 556.00 ns/op 553.00 ns/op 1.01
BeaconState.hashTreeRoot - 1 full validator 70.929 us/op 69.648 us/op 1.02
BeaconState.hashTreeRoot - 32 full validator 785.83 us/op 697.55 us/op 1.13
BeaconState.hashTreeRoot - 512 full validator 7.1064 ms/op 7.8482 ms/op 0.91
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 91.774 us/op 88.767 us/op 1.03
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.3848 ms/op 1.2808 ms/op 1.08
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 17.816 ms/op 16.503 ms/op 1.08
BeaconState.hashTreeRoot - 1 balances 75.207 us/op 63.569 us/op 1.18
BeaconState.hashTreeRoot - 32 balances 739.66 us/op 662.43 us/op 1.12
BeaconState.hashTreeRoot - 512 balances 7.0463 ms/op 6.3425 ms/op 1.11
BeaconState.hashTreeRoot - 250000 balances 110.91 ms/op 107.15 ms/op 1.04
aggregationBits - 2048 els - zipIndexesInBitList 37.075 us/op 26.480 us/op 1.40
regular array get 100000 times 78.353 us/op 60.549 us/op 1.29
wrappedArray get 100000 times 75.693 us/op 60.553 us/op 1.25
arrayWithProxy get 100000 times 34.527 ms/op 28.204 ms/op 1.22
ssz.Root.equals 563.00 ns/op 458.00 ns/op 1.23
byteArrayEquals 555.00 ns/op 452.00 ns/op 1.23
shuffle list - 16384 els 12.732 ms/op 11.150 ms/op 1.14
shuffle list - 250000 els 186.07 ms/op 165.30 ms/op 1.13
processSlot - 1 slots 14.341 us/op 12.872 us/op 1.11
processSlot - 32 slots 2.1348 ms/op 1.9469 ms/op 1.10
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 491.01 us/op 383.17 us/op 1.28
getCommitteeAssignments - req 1 vs - 250000 vc 6.2756 ms/op 5.4847 ms/op 1.14
getCommitteeAssignments - req 100 vs - 250000 vc 8.7505 ms/op 7.9738 ms/op 1.10
getCommitteeAssignments - req 1000 vs - 250000 vc 9.3961 ms/op 8.6078 ms/op 1.09
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 13.410 ns/op 7.4100 ns/op 1.81
state getBlockRootAtSlot - 250000 vs - 7PWei 1.3737 us/op 1.0705 us/op 1.28
computeProposers - vc 250000 20.163 ms/op 17.318 ms/op 1.16
computeEpochShuffling - vc 250000 196.60 ms/op 168.91 ms/op 1.16
getNextSyncCommittee - vc 250000 329.52 ms/op 287.70 ms/op 1.15

by benchmarkbot/action

@dapplion dapplion merged commit ca27458 into unstable Oct 5, 2022
@dapplion dapplion deleted the dapplion/unstable-e2e-web3signer-test branch October 5, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants