Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip signValidatorRegistration test #4644

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Skip signValidatorRegistration test #4644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/validator/test/e2e/web3signer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,10 @@ describe("web3signer signature test", function () {
await assertSameSignature("signVoluntaryExit", pubkeyBytes, validatorIndex, epoch);
});

it("signValidatorRegistration", async () => {
// ValidatorRegistration includes a timestamp so it's possible that web3signer instance and local instance
// sign different messages and this test fails. Disabling unless it can be proven deterministic
// eslint-disable-next-line mocha/no-skipped-tests
it.skip("signValidatorRegistration", async () => {
const regAttributes = {
feeRecipient: "0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
gasLimit: 1,
Expand Down