feat(blst): add new blst to all packages with bls #5493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
matthewkeil
changed the title
matthewkeil
force-pushed
the
mkeil/test-blst
branch
from
ca0c265
to
3b85012
Compare
34 tasks
|
@matthewkeil Please do not replace bls everywhere, only in the hot path verifying gossip data in the beacon chain. Such that do not change any other package beyond the beacon-node |
matthewkeil
commented
May 17, 2023
packages/beacon-node/package.json
Outdated
| @@ -98,6 +98,7 @@ | |||
| "@chainsafe/as-chacha20poly1305": "^0.1.0", | |||
| "@chainsafe/as-sha256": "^0.3.1", | |||
| "@chainsafe/bls": "7.1.1", | |||
| "@chainsafe/blst": "file:../../../blst-ts-2/rebuild", | |||
There was a problem hiding this comment.
@dapplion I have the new bindings stubbed in using a file import. How would you prefer I handle this for CI? Should I publish a version to @matthewkeil/blst or something similar? Or perhaps an odd semVer number that we can delete from @chainsage/blst?
There was a problem hiding this comment.
I published at blst-ts-test for now
…void import confusion
|
there was a build error on linux. I am updating the bindings and I built a workflow to test all three platforms in the |
Performance Report✔️ no performance regression detected Full benchmark results
|
Preliminary Resultsdeployed at: 8:30am EST Not all metrics are shown here. Just the ones that notable difference was seen (both better and worse). instance:
|
|
Converting to draft as this must not be merged until extensive testing in mainnet + internal audit of the lib |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The @chainsafe/blst library was rebuilt with Napi to put bls work on the
libuvthread pool in-lieu of a worker thread. The goal is to lower the overhead for bls work and to share it across all worker threads to increase bls throughput and to lower worker thread overhead. There will also be no latency with the messaging between workers.Description
Swapped out sync for async functions for all bls calls on main thread in
packages/beacon-nodeInclusions in
packages/beacon-nodepackage.jsonto include@chainsafe/blstImplementation notes for review
getAggregatedPubkeyinbeacon-node/src/chain/bls/utils.tshas a SWIG signatureSet (from@lodestar/state-transition) as param so converted in function to new binding format... not ideal but want to prevent upstream changesThese two were dependency of functions inside and outside of worker thread. were converted to two functions (sync and async:
verifySignatureSetsMaybeBatchinbeacon-node/src/chain/bls/maybeBatch.tsgetAggregatedPubkeyinbeacon-node/src/chain/bls/utils.tsFiles that still have
@chainsafe/bls:beacon-node/src/chain/bls/maybeBatch.tsbeacon-node/src/chain/bls/utils.tsbeacon-node/src/chain/bls/multithread/index.tsbeacon-node/src/chain/bls/multithread/worker.ts