Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert PR-5520 #5592

Merged
merged 2 commits into from
May 31, 2023
Merged

fix: revert PR-5520 #5592

merged 2 commits into from
May 31, 2023

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented May 31, 2023

Motivation

Description

@twoeths twoeths requested a review from a team as a code owner May 31, 2023 08:01
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: c09d8d4 Previous: d29cdc8 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 824.47 us/op 697.16 us/op 1.18
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 48.901 us/op 48.685 us/op 1.00
BLS verify - blst-native 1.2285 ms/op 1.2748 ms/op 0.96
BLS verifyMultipleSignatures 3 - blst-native 2.4915 ms/op 2.5767 ms/op 0.97
BLS verifyMultipleSignatures 8 - blst-native 5.4768 ms/op 5.4844 ms/op 1.00
BLS verifyMultipleSignatures 32 - blst-native 19.351 ms/op 19.212 ms/op 1.01
BLS aggregatePubkeys 32 - blst-native 26.019 us/op 25.849 us/op 1.01
BLS aggregatePubkeys 128 - blst-native 101.72 us/op 100.77 us/op 1.01
getAttestationsForBlock 59.040 ms/op 55.370 ms/op 1.07
isKnown best case - 1 super set check 262.00 ns/op 266.00 ns/op 0.98
isKnown normal case - 2 super set checks 251.00 ns/op 259.00 ns/op 0.97
isKnown worse case - 16 super set checks 250.00 ns/op 253.00 ns/op 0.99
CheckpointStateCache - add get delete 5.2570 us/op 6.0690 us/op 0.87
validate gossip signedAggregateAndProof - struct 2.8168 ms/op 2.7927 ms/op 1.01
validate gossip attestation - struct 1.3386 ms/op 1.3337 ms/op 1.00
pickEth1Vote - no votes 1.3037 ms/op 1.3289 ms/op 0.98
pickEth1Vote - max votes 10.607 ms/op 9.4448 ms/op 1.12
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.2847 ms/op 9.3588 ms/op 0.99
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 15.257 ms/op 15.647 ms/op 0.98
pickEth1Vote - Eth1Data fastSerialize value x2048 764.54 us/op 722.60 us/op 1.06
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.9615 ms/op 9.5990 ms/op 0.52
bytes32 toHexString 515.00 ns/op 710.00 ns/op 0.73
bytes32 Buffer.toString(hex) 375.00 ns/op 423.00 ns/op 0.89
bytes32 Buffer.toString(hex) from Uint8Array 573.00 ns/op 652.00 ns/op 0.88
bytes32 Buffer.toString(hex) + 0x 384.00 ns/op 413.00 ns/op 0.93
Object access 1 prop 0.16500 ns/op 0.17800 ns/op 0.93
Map access 1 prop 0.17400 ns/op 0.17000 ns/op 1.02
Object get x1000 6.8550 ns/op 6.8770 ns/op 1.00
Map get x1000 0.62600 ns/op 0.69300 ns/op 0.90
Object set x1000 56.075 ns/op 59.057 ns/op 0.95
Map set x1000 46.748 ns/op 54.609 ns/op 0.86
Return object 10000 times 0.24550 ns/op 0.25710 ns/op 0.95
Throw Error 10000 times 4.3026 us/op 4.3775 us/op 0.98
fastMsgIdFn sha256 / 200 bytes 3.4980 us/op 3.6280 us/op 0.96
fastMsgIdFn h32 xxhash / 200 bytes 307.00 ns/op 338.00 ns/op 0.91
fastMsgIdFn h64 xxhash / 200 bytes 454.00 ns/op 492.00 ns/op 0.92
fastMsgIdFn sha256 / 1000 bytes 11.864 us/op 11.936 us/op 0.99
fastMsgIdFn h32 xxhash / 1000 bytes 444.00 ns/op 456.00 ns/op 0.97
fastMsgIdFn h64 xxhash / 1000 bytes 534.00 ns/op 550.00 ns/op 0.97
fastMsgIdFn sha256 / 10000 bytes 105.66 us/op 108.96 us/op 0.97
fastMsgIdFn h32 xxhash / 10000 bytes 1.9840 us/op 2.0680 us/op 0.96
fastMsgIdFn h64 xxhash / 10000 bytes 1.4300 us/op 1.4900 us/op 0.96
enrSubnets - fastDeserialize 64 bits 1.3540 us/op 1.7680 us/op 0.77
enrSubnets - ssz BitVector 64 bits 542.00 ns/op 653.00 ns/op 0.83
enrSubnets - fastDeserialize 4 bits 182.00 ns/op 211.00 ns/op 0.86
enrSubnets - ssz BitVector 4 bits 563.00 ns/op 633.00 ns/op 0.89
prioritizePeers score -10:0 att 32-0.1 sync 2-0 125.79 us/op 120.19 us/op 1.05
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 152.97 us/op 167.46 us/op 0.91
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 181.47 us/op 207.78 us/op 0.87
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 338.30 us/op 415.32 us/op 0.81
prioritizePeers score 0:0 att 64-1 sync 4-1 428.63 us/op 414.38 us/op 1.03
array of 16000 items push then shift 1.6786 us/op 1.7277 us/op 0.97
LinkedList of 16000 items push then shift 9.0150 ns/op 9.7710 ns/op 0.92
array of 16000 items push then pop 101.89 ns/op 112.35 ns/op 0.91
LinkedList of 16000 items push then pop 8.6090 ns/op 9.3250 ns/op 0.92
array of 24000 items push then shift 2.3507 us/op 2.5855 us/op 0.91
LinkedList of 24000 items push then shift 8.7620 ns/op 9.5020 ns/op 0.92
array of 24000 items push then pop 76.038 ns/op 94.802 ns/op 0.80
LinkedList of 24000 items push then pop 8.5450 ns/op 9.6390 ns/op 0.89
intersect bitArray bitLen 8 13.357 ns/op 14.342 ns/op 0.93
intersect array and set length 8 78.438 ns/op 95.981 ns/op 0.82
intersect bitArray bitLen 128 42.320 ns/op 47.457 ns/op 0.89
intersect array and set length 128 999.34 ns/op 1.3411 us/op 0.75
Buffer.concat 32 items 2.7550 us/op 3.2400 us/op 0.85
Uint8Array.set 32 items 2.7690 us/op 3.1620 us/op 0.88
transfer serialized Status (84 B) 2.0100 us/op 2.3660 us/op 0.85
copy serialized Status (84 B) 1.6760 us/op 1.9380 us/op 0.86
transfer serialized SignedVoluntaryExit (112 B) 2.1000 us/op 2.3980 us/op 0.88
copy serialized SignedVoluntaryExit (112 B) 1.7150 us/op 2.0970 us/op 0.82
transfer serialized ProposerSlashing (416 B) 2.5030 us/op 3.1430 us/op 0.80
copy serialized ProposerSlashing (416 B) 2.4870 us/op 3.3130 us/op 0.75
transfer serialized Attestation (485 B) 2.7860 us/op 3.3480 us/op 0.83
copy serialized Attestation (485 B) 2.9190 us/op 3.1180 us/op 0.94
transfer serialized AttesterSlashing (33232 B) 3.0890 us/op 3.1390 us/op 0.98
copy serialized AttesterSlashing (33232 B) 5.8430 us/op 9.4940 us/op 0.62
transfer serialized Small SignedBeaconBlock (128000 B) 3.0650 us/op 3.1840 us/op 0.96
copy serialized Small SignedBeaconBlock (128000 B) 12.974 us/op 24.995 us/op 0.52
transfer serialized Avg SignedBeaconBlock (200000 B) 3.6270 us/op 3.7830 us/op 0.96
copy serialized Avg SignedBeaconBlock (200000 B) 20.559 us/op 37.787 us/op 0.54
transfer serialized BlobsSidecar (524380 B) 3.2310 us/op 4.2400 us/op 0.76
copy serialized BlobsSidecar (524380 B) 81.754 us/op 107.72 us/op 0.76
transfer serialized Big SignedBeaconBlock (1000000 B) 3.2080 us/op 3.8780 us/op 0.83
copy serialized Big SignedBeaconBlock (1000000 B) 281.96 us/op 282.55 us/op 1.00
pass gossip attestations to forkchoice per slot 2.2675 ms/op 2.4441 ms/op 0.93
computeDeltas 3.4622 ms/op 3.3564 ms/op 1.03
computeProposerBoostScoreFromBalances 1.8065 ms/op 1.8532 ms/op 0.97
altair processAttestation - 250000 vs - 7PWei normalcase 2.1334 ms/op 3.5125 ms/op 0.61
altair processAttestation - 250000 vs - 7PWei worstcase 3.2802 ms/op 4.5611 ms/op 0.72
altair processAttestation - setStatus - 1/6 committees join 132.83 us/op 147.05 us/op 0.90
altair processAttestation - setStatus - 1/3 committees join 277.14 us/op 292.84 us/op 0.95
altair processAttestation - setStatus - 1/2 committees join 371.39 us/op 383.16 us/op 0.97
altair processAttestation - setStatus - 2/3 committees join 466.61 us/op 478.91 us/op 0.97
altair processAttestation - setStatus - 4/5 committees join 657.63 us/op 712.70 us/op 0.92
altair processAttestation - setStatus - 100% committees join 759.17 us/op 869.15 us/op 0.87
altair processBlock - 250000 vs - 7PWei normalcase 18.719 ms/op 19.675 ms/op 0.95
altair processBlock - 250000 vs - 7PWei normalcase hashState 26.610 ms/op 26.645 ms/op 1.00
altair processBlock - 250000 vs - 7PWei worstcase 45.743 ms/op 54.305 ms/op 0.84
altair processBlock - 250000 vs - 7PWei worstcase hashState 66.398 ms/op 78.627 ms/op 0.84
phase0 processBlock - 250000 vs - 7PWei normalcase 1.9905 ms/op 2.3882 ms/op 0.83
phase0 processBlock - 250000 vs - 7PWei worstcase 27.574 ms/op 34.607 ms/op 0.80
altair processEth1Data - 250000 vs - 7PWei normalcase 457.27 us/op 540.34 us/op 0.85
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 6.5220 us/op 9.7790 us/op 0.67
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 19.515 us/op 32.909 us/op 0.59
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 8.1370 us/op 13.363 us/op 0.61
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 6.4150 us/op 11.771 us/op 0.54
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 75.007 us/op 110.04 us/op 0.68
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 650.66 us/op 711.37 us/op 0.91
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 894.40 us/op 907.19 us/op 0.99
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 883.11 us/op 939.13 us/op 0.94
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.3870 ms/op 2.3975 ms/op 1.00
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.6987 ms/op 1.6684 ms/op 1.02
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.3008 ms/op 4.1364 ms/op 1.04
Tree 40 250000 create 303.36 ms/op 458.53 ms/op 0.66
Tree 40 250000 get(125000) 180.46 ns/op 202.18 ns/op 0.89
Tree 40 250000 set(125000) 901.41 ns/op 1.0885 us/op 0.83
Tree 40 250000 toArray() 19.081 ms/op 23.077 ms/op 0.83
Tree 40 250000 iterate all - toArray() + loop 19.287 ms/op 23.268 ms/op 0.83
Tree 40 250000 iterate all - get(i) 75.185 ms/op 77.065 ms/op 0.98
MutableVector 250000 create 10.542 ms/op 11.792 ms/op 0.89
MutableVector 250000 get(125000) 6.2260 ns/op 6.8090 ns/op 0.91
MutableVector 250000 set(125000) 270.76 ns/op 289.24 ns/op 0.94
MutableVector 250000 toArray() 3.3670 ms/op 3.6301 ms/op 0.93
MutableVector 250000 iterate all - toArray() + loop 3.6941 ms/op 3.7607 ms/op 0.98
MutableVector 250000 iterate all - get(i) 1.5562 ms/op 1.5595 ms/op 1.00
Array 250000 create 2.7567 ms/op 3.0846 ms/op 0.89
Array 250000 clone - spread 1.1240 ms/op 1.2064 ms/op 0.93
Array 250000 get(125000) 0.54000 ns/op 0.60200 ns/op 0.90
Array 250000 set(125000) 0.62000 ns/op 0.64200 ns/op 0.97
Array 250000 iterate all - loop 86.668 us/op 95.139 us/op 0.91
effectiveBalanceIncrements clone Uint8Array 300000 36.392 us/op 37.128 us/op 0.98
effectiveBalanceIncrements clone MutableVector 300000 315.00 ns/op 355.00 ns/op 0.89
effectiveBalanceIncrements rw all Uint8Array 300000 167.32 us/op 172.46 us/op 0.97
effectiveBalanceIncrements rw all MutableVector 300000 87.123 ms/op 82.987 ms/op 1.05
phase0 afterProcessEpoch - 250000 vs - 7PWei 113.59 ms/op 119.18 ms/op 0.95
phase0 beforeProcessEpoch - 250000 vs - 7PWei 38.923 ms/op 40.941 ms/op 0.95
altair processEpoch - mainnet_e81889 306.19 ms/op 302.11 ms/op 1.01
mainnet_e81889 - altair beforeProcessEpoch 57.420 ms/op 50.723 ms/op 1.13
mainnet_e81889 - altair processJustificationAndFinalization 21.106 us/op 17.475 us/op 1.21
mainnet_e81889 - altair processInactivityUpdates 6.3501 ms/op 5.1477 ms/op 1.23
mainnet_e81889 - altair processRewardsAndPenalties 68.059 ms/op 60.363 ms/op 1.13
mainnet_e81889 - altair processRegistryUpdates 3.3370 us/op 2.3930 us/op 1.39
mainnet_e81889 - altair processSlashings 905.00 ns/op 503.00 ns/op 1.80
mainnet_e81889 - altair processEth1DataReset 517.00 ns/op 662.00 ns/op 0.78
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.2629 ms/op 1.2400 ms/op 1.02
mainnet_e81889 - altair processSlashingsReset 4.4650 us/op 5.5130 us/op 0.81
mainnet_e81889 - altair processRandaoMixesReset 7.4440 us/op 6.6280 us/op 1.12
mainnet_e81889 - altair processHistoricalRootsUpdate 990.00 ns/op 814.00 ns/op 1.22
mainnet_e81889 - altair processParticipationFlagUpdates 5.3040 us/op 2.6150 us/op 2.03
mainnet_e81889 - altair processSyncCommitteeUpdates 1.2840 us/op 646.00 ns/op 1.99
mainnet_e81889 - altair afterProcessEpoch 176.47 ms/op 126.23 ms/op 1.40
phase0 processEpoch - mainnet_e58758 438.80 ms/op 390.59 ms/op 1.12
mainnet_e58758 - phase0 beforeProcessEpoch 161.17 ms/op 148.21 ms/op 1.09
mainnet_e58758 - phase0 processJustificationAndFinalization 25.879 us/op 19.494 us/op 1.33
mainnet_e58758 - phase0 processRewardsAndPenalties 76.471 ms/op 62.552 ms/op 1.22
mainnet_e58758 - phase0 processRegistryUpdates 15.229 us/op 8.2020 us/op 1.86
mainnet_e58758 - phase0 processSlashings 1.1240 us/op 553.00 ns/op 2.03
mainnet_e58758 - phase0 processEth1DataReset 1.6600 us/op 646.00 ns/op 2.57
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.7004 ms/op 1.1612 ms/op 1.46
mainnet_e58758 - phase0 processSlashingsReset 8.0740 us/op 3.7040 us/op 2.18
mainnet_e58758 - phase0 processRandaoMixesReset 8.4710 us/op 5.4360 us/op 1.56
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.1420 us/op 787.00 ns/op 1.45
mainnet_e58758 - phase0 processParticipationRecordUpdates 8.9670 us/op 4.3550 us/op 2.06
mainnet_e58758 - phase0 afterProcessEpoch 105.54 ms/op 99.613 ms/op 1.06
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.7350 ms/op 1.2742 ms/op 1.36
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.0239 ms/op 1.5601 ms/op 1.94
altair processInactivityUpdates - 250000 normalcase 25.325 ms/op 23.804 ms/op 1.06
altair processInactivityUpdates - 250000 worstcase 30.081 ms/op 24.636 ms/op 1.22
phase0 processRegistryUpdates - 250000 normalcase 15.797 us/op 7.3870 us/op 2.14
phase0 processRegistryUpdates - 250000 badcase_full_deposits 291.28 us/op 275.19 us/op 1.06
phase0 processRegistryUpdates - 250000 worstcase 0.5 151.82 ms/op 131.36 ms/op 1.16
altair processRewardsAndPenalties - 250000 normalcase 81.489 ms/op 70.459 ms/op 1.16
altair processRewardsAndPenalties - 250000 worstcase 79.822 ms/op 71.391 ms/op 1.12
phase0 getAttestationDeltas - 250000 normalcase 10.481 ms/op 9.0773 ms/op 1.15
phase0 getAttestationDeltas - 250000 worstcase 9.7032 ms/op 7.1001 ms/op 1.37
phase0 processSlashings - 250000 worstcase 4.2734 ms/op 3.7407 ms/op 1.14
altair processSyncCommitteeUpdates - 250000 200.18 ms/op 191.05 ms/op 1.05
BeaconState.hashTreeRoot - No change 368.00 ns/op 281.00 ns/op 1.31
BeaconState.hashTreeRoot - 1 full validator 55.217 us/op 51.616 us/op 1.07
BeaconState.hashTreeRoot - 32 full validator 507.24 us/op 601.92 us/op 0.84
BeaconState.hashTreeRoot - 512 full validator 5.9468 ms/op 6.2212 ms/op 0.96
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 73.401 us/op 69.004 us/op 1.06
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 976.24 us/op 1.0030 ms/op 0.97
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 13.778 ms/op 13.703 ms/op 1.01
BeaconState.hashTreeRoot - 1 balances 54.807 us/op 53.658 us/op 1.02
BeaconState.hashTreeRoot - 32 balances 487.89 us/op 474.52 us/op 1.03
BeaconState.hashTreeRoot - 512 balances 4.8963 ms/op 5.1702 ms/op 0.95
BeaconState.hashTreeRoot - 250000 balances 73.627 ms/op 80.036 ms/op 0.92
aggregationBits - 2048 els - zipIndexesInBitList 23.117 us/op 19.610 us/op 1.18
regular array get 100000 times 35.404 us/op 34.179 us/op 1.04
wrappedArray get 100000 times 36.115 us/op 34.115 us/op 1.06
arrayWithProxy get 100000 times 18.377 ms/op 17.922 ms/op 1.03
ssz.Root.equals 606.00 ns/op 576.00 ns/op 1.05
byteArrayEquals 598.00 ns/op 556.00 ns/op 1.08
shuffle list - 16384 els 7.2611 ms/op 6.8334 ms/op 1.06
shuffle list - 250000 els 106.34 ms/op 97.835 ms/op 1.09
processSlot - 1 slots 9.9550 us/op 9.0890 us/op 1.10
processSlot - 32 slots 1.4790 ms/op 1.3411 ms/op 1.10
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 39.266 ms/op 37.779 ms/op 1.04
getCommitteeAssignments - req 1 vs - 250000 vc 3.0237 ms/op 2.9445 ms/op 1.03
getCommitteeAssignments - req 100 vs - 250000 vc 4.2878 ms/op 4.1692 ms/op 1.03
getCommitteeAssignments - req 1000 vs - 250000 vc 4.6508 ms/op 4.5042 ms/op 1.03
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.3000 ns/op 4.5000 ns/op 1.18
state getBlockRootAtSlot - 250000 vs - 7PWei 767.19 ns/op 682.75 ns/op 1.12
computeProposers - vc 250000 11.415 ms/op 10.251 ms/op 1.11
computeEpochShuffling - vc 250000 108.13 ms/op 103.12 ms/op 1.05
getNextSyncCommittee - vc 250000 190.16 ms/op 167.78 ms/op 1.13
computeSigningRoot for AttestationData 14.682 us/op 13.741 us/op 1.07
hash AttestationData serialized data then Buffer.toString(base64) 2.5688 us/op 2.5177 us/op 1.02
toHexString serialized data 1.2271 us/op 1.0893 us/op 1.13
Buffer.toString(base64) 362.87 ns/op 321.79 ns/op 1.13

by benchmarkbot/action

g11tech
g11tech approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@twoeths twoeths merged commit 888c599 into unstable May 31, 2023
11 checks passed
@twoeths twoeths deleted the tuyen/revert_PR_5520 branch May 31, 2023 08:29
@twoeths twoeths restored the tuyen/revert_PR_5520 branch May 31, 2023 08:40
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
34a9699 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
e9dcea0 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
6eb9221 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
1a83897 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
51cbfa8 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
5f2eec9 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
5f4ca9e 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
d8670a8 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
cd55a12 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
b4d36b2 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
2da28d8 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
b2a3949 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
3a81a61 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
2101f95 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
1ee9ccb 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
27fb795 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
9260972 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
5bced4e 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
7d62137 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twoeths @wemeetagain @g11tech