Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change archiving strategy to always store last finalized #5520

Merged
merged 4 commits into from May 23, 2023
Merged

refactor: change archiving strategy to always store last finalized #5520

merged 4 commits into from May 23, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented May 22, 2023

Previously last finalized was not always written, this leads to restarts starting from way back
Changed the strategy to always update finalized state and also simplified the state cleanup logic + added tests

@g11tech g11tech requested a review from a team as a code owner May 22, 2023 16:33
@g11tech g11tech changed the title refac: change archiving strategy to always store last finalized refactor: change archiving strategy to always store last finalized May 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023 •
edited

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: d0b9c62 Previous: 42c8097 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 848.06 us/op 1.0613 ms/op 0.80
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 43.607 us/op 43.243 us/op 1.01
BLS verify - blst-native 1.1737 ms/op 1.1676 ms/op 1.01
BLS verifyMultipleSignatures 3 - blst-native 2.3863 ms/op 2.3748 ms/op 1.00
BLS verifyMultipleSignatures 8 - blst-native 5.1231 ms/op 5.1080 ms/op 1.00
BLS verifyMultipleSignatures 32 - blst-native 18.532 ms/op 18.442 ms/op 1.00
BLS aggregatePubkeys 32 - blst-native 24.697 us/op 24.713 us/op 1.00
BLS aggregatePubkeys 128 - blst-native 96.922 us/op 96.263 us/op 1.01
getAttestationsForBlock 50.621 ms/op 60.538 ms/op 0.84
isKnown best case - 1 super set check 254.00 ns/op 280.00 ns/op 0.91
isKnown normal case - 2 super set checks 243.00 ns/op 272.00 ns/op 0.89
isKnown worse case - 16 super set checks 241.00 ns/op 274.00 ns/op 0.88
CheckpointStateCache - add get delete 4.8040 us/op 4.8420 us/op 0.99
validate gossip signedAggregateAndProof - struct 2.6648 ms/op 2.6868 ms/op 0.99
validate gossip attestation - struct 1.2738 ms/op 1.2880 ms/op 0.99
pickEth1Vote - no votes 1.2192 ms/op 1.2135 ms/op 1.00
pickEth1Vote - max votes 9.5094 ms/op 13.496 ms/op 0.70
pickEth1Vote - Eth1Data hashTreeRoot value x2048 8.5251 ms/op 8.0801 ms/op 1.06
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 13.938 ms/op 15.545 ms/op 0.90
pickEth1Vote - Eth1Data fastSerialize value x2048 618.89 us/op 621.78 us/op 1.00
pickEth1Vote - Eth1Data fastSerialize tree x2048 7.8730 ms/op 9.0688 ms/op 0.87
bytes32 toHexString 468.00 ns/op 481.00 ns/op 0.97
bytes32 Buffer.toString(hex) 329.00 ns/op 326.00 ns/op 1.01
bytes32 Buffer.toString(hex) from Uint8Array 528.00 ns/op 545.00 ns/op 0.97
bytes32 Buffer.toString(hex) + 0x 326.00 ns/op 330.00 ns/op 0.99
Object access 1 prop 0.15700 ns/op 0.15800 ns/op 0.99
Map access 1 prop 0.15000 ns/op 0.15700 ns/op 0.96
Object get x1000 6.6960 ns/op 6.4070 ns/op 1.05
Map get x1000 0.58600 ns/op 0.58600 ns/op 1.00
Object set x1000 49.419 ns/op 49.065 ns/op 1.01
Map set x1000 41.539 ns/op 40.643 ns/op 1.02
Return object 10000 times 0.22890 ns/op 0.22650 ns/op 1.01
Throw Error 10000 times 4.0514 us/op 4.0484 us/op 1.00
fastMsgIdFn sha256 / 200 bytes 3.2950 us/op 3.2890 us/op 1.00
fastMsgIdFn h32 xxhash / 200 bytes 265.00 ns/op 268.00 ns/op 0.99
fastMsgIdFn h64 xxhash / 200 bytes 376.00 ns/op 376.00 ns/op 1.00
fastMsgIdFn sha256 / 1000 bytes 11.120 us/op 11.226 us/op 0.99
fastMsgIdFn h32 xxhash / 1000 bytes 387.00 ns/op 391.00 ns/op 0.99
fastMsgIdFn h64 xxhash / 1000 bytes 450.00 ns/op 442.00 ns/op 1.02
fastMsgIdFn sha256 / 10000 bytes 100.50 us/op 100.28 us/op 1.00
fastMsgIdFn h32 xxhash / 10000 bytes 1.8760 us/op 1.8250 us/op 1.03
fastMsgIdFn h64 xxhash / 10000 bytes 1.3360 us/op 1.2970 us/op 1.03
enrSubnets - fastDeserialize 64 bits 1.2240 us/op 1.1940 us/op 1.03
enrSubnets - ssz BitVector 64 bits 460.00 ns/op 468.00 ns/op 0.98
enrSubnets - fastDeserialize 4 bits 160.00 ns/op 160.00 ns/op 1.00
enrSubnets - ssz BitVector 4 bits 467.00 ns/op 467.00 ns/op 1.00
prioritizePeers score -10:0 att 32-0.1 sync 2-0 104.16 us/op 100.82 us/op 1.03
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 130.25 us/op 124.55 us/op 1.05
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 163.37 us/op 158.29 us/op 1.03
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 293.93 us/op 284.58 us/op 1.03
prioritizePeers score 0:0 att 64-1 sync 4-1 357.40 us/op 340.36 us/op 1.05
array of 16000 items push then shift 1.5739 us/op 1.5654 us/op 1.01
LinkedList of 16000 items push then shift 8.5650 ns/op 8.4760 ns/op 1.01
array of 16000 items push then pop 78.943 ns/op 68.754 ns/op 1.15
LinkedList of 16000 items push then pop 8.3680 ns/op 8.2180 ns/op 1.02
array of 24000 items push then shift 2.2977 us/op 2.2666 us/op 1.01
LinkedList of 24000 items push then shift 8.5580 ns/op 10.483 ns/op 0.82
array of 24000 items push then pop 75.877 ns/op 69.557 ns/op 1.09
LinkedList of 24000 items push then pop 8.2250 ns/op 9.0500 ns/op 0.91
intersect bitArray bitLen 8 12.792 ns/op 12.717 ns/op 1.01
intersect array and set length 8 73.974 ns/op 82.971 ns/op 0.89
intersect bitArray bitLen 128 42.489 ns/op 42.240 ns/op 1.01
intersect array and set length 128 1.0128 us/op 991.39 ns/op 1.02
Buffer.concat 32 items 2.7710 us/op 2.4890 us/op 1.11
Uint8Array.set 32 items 2.8210 us/op 2.4760 us/op 1.14
pass gossip attestations to forkchoice per slot 2.6488 ms/op 2.1748 ms/op 1.22
computeDeltas 3.3923 ms/op 4.3628 ms/op 0.78
computeProposerBoostScoreFromBalances 1.7428 ms/op 1.7557 ms/op 0.99
altair processAttestation - 250000 vs - 7PWei normalcase 2.0443 ms/op 2.1166 ms/op 0.97
altair processAttestation - 250000 vs - 7PWei worstcase 3.2061 ms/op 3.3155 ms/op 0.97
altair processAttestation - setStatus - 1/6 committees join 133.39 us/op 135.00 us/op 0.99
altair processAttestation - setStatus - 1/3 committees join 264.59 us/op 267.43 us/op 0.99
altair processAttestation - setStatus - 1/2 committees join 355.48 us/op 358.37 us/op 0.99
altair processAttestation - setStatus - 2/3 committees join 445.97 us/op 441.90 us/op 1.01
altair processAttestation - setStatus - 4/5 committees join 629.35 us/op 629.50 us/op 1.00
altair processAttestation - setStatus - 100% committees join 735.13 us/op 740.91 us/op 0.99
altair processBlock - 250000 vs - 7PWei normalcase 16.676 ms/op 21.518 ms/op 0.78
altair processBlock - 250000 vs - 7PWei normalcase hashState 28.163 ms/op 30.202 ms/op 0.93
altair processBlock - 250000 vs - 7PWei worstcase 46.532 ms/op 64.927 ms/op 0.72
altair processBlock - 250000 vs - 7PWei worstcase hashState 65.411 ms/op 81.709 ms/op 0.80
phase0 processBlock - 250000 vs - 7PWei normalcase 1.9436 ms/op 1.9716 ms/op 0.99
phase0 processBlock - 250000 vs - 7PWei worstcase 27.405 ms/op 26.871 ms/op 1.02
altair processEth1Data - 250000 vs - 7PWei normalcase 417.97 us/op 457.16 us/op 0.91
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 6.8380 us/op 6.5520 us/op 1.04
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 19.094 us/op 19.492 us/op 0.98
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 8.1440 us/op 12.523 us/op 0.65
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 6.3380 us/op 6.2550 us/op 1.01
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 74.177 us/op 123.19 us/op 0.60
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 612.05 us/op 1.2331 ms/op 0.50
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 901.42 us/op 1.6548 ms/op 0.54
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 870.27 us/op 1.6198 ms/op 0.54
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 2.1506 ms/op 2.1067 ms/op 1.02
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 1.4928 ms/op 2.2863 ms/op 0.65
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 3.5492 ms/op 3.7238 ms/op 0.95
Tree 40 250000 create 281.49 ms/op 293.31 ms/op 0.96
Tree 40 250000 get(125000) 175.04 ns/op 172.07 ns/op 1.02
Tree 40 250000 set(125000) 823.56 ns/op 856.72 ns/op 0.96
Tree 40 250000 toArray() 16.911 ms/op 16.552 ms/op 1.02
Tree 40 250000 iterate all - toArray() + loop 16.940 ms/op 16.592 ms/op 1.02
Tree 40 250000 iterate all - get(i) 64.792 ms/op 64.983 ms/op 1.00
MutableVector 250000 create 9.5789 ms/op 17.760 ms/op 0.54
MutableVector 250000 get(125000) 6.2100 ns/op 6.3060 ns/op 0.98
MutableVector 250000 set(125000) 248.74 ns/op 253.38 ns/op 0.98
MutableVector 250000 toArray() 2.7757 ms/op 2.8382 ms/op 0.98
MutableVector 250000 iterate all - toArray() + loop 2.7393 ms/op 2.9702 ms/op 0.92
MutableVector 250000 iterate all - get(i) 1.4599 ms/op 1.4740 ms/op 0.99
Array 250000 create 2.4829 ms/op 2.6621 ms/op 0.93
Array 250000 clone - spread 1.2332 ms/op 1.1076 ms/op 1.11
Array 250000 get(125000) 0.58400 ns/op 0.50700 ns/op 1.15
Array 250000 set(125000) 0.67600 ns/op 0.59000 ns/op 1.15
Array 250000 iterate all - loop 79.259 us/op 80.047 us/op 0.99
effectiveBalanceIncrements clone Uint8Array 300000 29.115 us/op 23.934 us/op 1.22
effectiveBalanceIncrements clone MutableVector 300000 398.00 ns/op 310.00 ns/op 1.28
effectiveBalanceIncrements rw all Uint8Array 300000 162.11 us/op 162.89 us/op 1.00
effectiveBalanceIncrements rw all MutableVector 300000 80.950 ms/op 75.310 ms/op 1.07
phase0 afterProcessEpoch - 250000 vs - 7PWei 114.01 ms/op 108.16 ms/op 1.05
phase0 beforeProcessEpoch - 250000 vs - 7PWei 39.119 ms/op 42.801 ms/op 0.91
altair processEpoch - mainnet_e81889 297.23 ms/op 339.76 ms/op 0.87
mainnet_e81889 - altair beforeProcessEpoch 50.461 ms/op 67.149 ms/op 0.75
mainnet_e81889 - altair processJustificationAndFinalization 15.671 us/op 27.114 us/op 0.58
mainnet_e81889 - altair processInactivityUpdates 5.5984 ms/op 5.2981 ms/op 1.06
mainnet_e81889 - altair processRewardsAndPenalties 72.589 ms/op 85.659 ms/op 0.85
mainnet_e81889 - altair processRegistryUpdates 2.6690 us/op 4.6460 us/op 0.57
mainnet_e81889 - altair processSlashings 526.00 ns/op 791.00 ns/op 0.66
mainnet_e81889 - altair processEth1DataReset 561.00 ns/op 948.00 ns/op 0.59
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.1970 ms/op 2.2928 ms/op 0.52
mainnet_e81889 - altair processSlashingsReset 4.6660 us/op 5.6860 us/op 0.82
mainnet_e81889 - altair processRandaoMixesReset 4.3300 us/op 7.2820 us/op 0.59
mainnet_e81889 - altair processHistoricalRootsUpdate 554.00 ns/op 1.1370 us/op 0.49
mainnet_e81889 - altair processParticipationFlagUpdates 2.2290 us/op 4.2150 us/op 0.53
mainnet_e81889 - altair processSyncCommitteeUpdates 564.00 ns/op 804.00 ns/op 0.70
mainnet_e81889 - altair afterProcessEpoch 115.04 ms/op 115.27 ms/op 1.00
phase0 processEpoch - mainnet_e58758 310.58 ms/op 360.22 ms/op 0.86
mainnet_e58758 - phase0 beforeProcessEpoch 120.57 ms/op 130.60 ms/op 0.92
mainnet_e58758 - phase0 processJustificationAndFinalization 15.630 us/op 25.605 us/op 0.61
mainnet_e58758 - phase0 processRewardsAndPenalties 54.088 ms/op 56.334 ms/op 0.96
mainnet_e58758 - phase0 processRegistryUpdates 7.4730 us/op 12.314 us/op 0.61
mainnet_e58758 - phase0 processSlashings 511.00 ns/op 960.00 ns/op 0.53
mainnet_e58758 - phase0 processEth1DataReset 500.00 ns/op 1.0270 us/op 0.49
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 939.65 us/op 1.8749 ms/op 0.50
mainnet_e58758 - phase0 processSlashingsReset 2.8990 us/op 5.1290 us/op 0.57
mainnet_e58758 - phase0 processRandaoMixesReset 4.3360 us/op 7.8540 us/op 0.55
mainnet_e58758 - phase0 processHistoricalRootsUpdate 604.00 ns/op 1.0980 us/op 0.55
mainnet_e58758 - phase0 processParticipationRecordUpdates 3.8810 us/op 6.9040 us/op 0.56
mainnet_e58758 - phase0 afterProcessEpoch 93.822 ms/op 100.87 ms/op 0.93
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.1993 ms/op 1.9954 ms/op 0.60
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4264 ms/op 2.6120 ms/op 0.55
altair processInactivityUpdates - 250000 normalcase 19.527 ms/op 26.111 ms/op 0.75
altair processInactivityUpdates - 250000 worstcase 21.188 ms/op 25.465 ms/op 0.83
phase0 processRegistryUpdates - 250000 normalcase 6.4180 us/op 10.292 us/op 0.62
phase0 processRegistryUpdates - 250000 badcase_full_deposits 228.77 us/op 390.32 us/op 0.59
phase0 processRegistryUpdates - 250000 worstcase 0.5 115.61 ms/op 138.39 ms/op 0.84
altair processRewardsAndPenalties - 250000 normalcase 50.874 ms/op 63.675 ms/op 0.80
altair processRewardsAndPenalties - 250000 worstcase 53.919 ms/op 68.111 ms/op 0.79
phase0 getAttestationDeltas - 250000 normalcase 6.3521 ms/op 6.4775 ms/op 0.98
phase0 getAttestationDeltas - 250000 worstcase 6.4351 ms/op 6.6190 ms/op 0.97
phase0 processSlashings - 250000 worstcase 3.5465 ms/op 3.7086 ms/op 0.96
altair processSyncCommitteeUpdates - 250000 167.07 ms/op 181.22 ms/op 0.92
BeaconState.hashTreeRoot - No change 250.00 ns/op 265.00 ns/op 0.94
BeaconState.hashTreeRoot - 1 full validator 50.101 us/op 60.598 us/op 0.83
BeaconState.hashTreeRoot - 32 full validator 496.88 us/op 585.76 us/op 0.85
BeaconState.hashTreeRoot - 512 full validator 5.2371 ms/op 6.2328 ms/op 0.84
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 61.136 us/op 65.393 us/op 0.93
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 846.14 us/op 1.0270 ms/op 0.82
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 10.850 ms/op 10.905 ms/op 0.99
BeaconState.hashTreeRoot - 1 balances 46.573 us/op 49.977 us/op 0.93
BeaconState.hashTreeRoot - 32 balances 431.75 us/op 618.73 us/op 0.70
BeaconState.hashTreeRoot - 512 balances 4.1538 ms/op 4.9881 ms/op 0.83
BeaconState.hashTreeRoot - 250000 balances 76.230 ms/op 78.168 ms/op 0.98
aggregationBits - 2048 els - zipIndexesInBitList 15.799 us/op 15.482 us/op 1.02
regular array get 100000 times 31.009 us/op 37.800 us/op 0.82
wrappedArray get 100000 times 31.009 us/op 31.512 us/op 0.98
arrayWithProxy get 100000 times 15.075 ms/op 15.290 ms/op 0.99
ssz.Root.equals 519.00 ns/op 525.00 ns/op 0.99
byteArrayEquals 511.00 ns/op 516.00 ns/op 0.99
shuffle list - 16384 els 6.6964 ms/op 6.4694 ms/op 1.04
shuffle list - 250000 els 97.745 ms/op 94.987 ms/op 1.03
processSlot - 1 slots 8.6340 us/op 8.4010 us/op 1.03
processSlot - 32 slots 1.3072 ms/op 1.2988 ms/op 1.01
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 33.222 ms/op 41.535 ms/op 0.80
getCommitteeAssignments - req 1 vs - 250000 vc 2.7277 ms/op 2.7731 ms/op 0.98
getCommitteeAssignments - req 100 vs - 250000 vc 3.8734 ms/op 3.9380 ms/op 0.98
getCommitteeAssignments - req 1000 vs - 250000 vc 4.3335 ms/op 4.4323 ms/op 0.98
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.3700 ns/op 4.4400 ns/op 0.98
state getBlockRootAtSlot - 250000 vs - 7PWei 847.04 ns/op 960.69 ns/op 0.88
computeProposers - vc 250000 10.097 ms/op 10.457 ms/op 0.97
computeEpochShuffling - vc 250000 96.695 ms/op 99.694 ms/op 0.97
getNextSyncCommittee - vc 250000 167.85 ms/op 170.20 ms/op 0.99
computeSigningRoot for AttestationData 13.126 us/op 12.652 us/op 1.04
hash AttestationData serialized data then Buffer.toString(base64) 2.2842 us/op 2.3378 us/op 0.98
toHexString serialized data 1.0149 us/op 1.0404 us/op 0.98
Buffer.toString(base64) 309.51 ns/op 309.47 ns/op 1.00

by benchmarkbot/action

twoeths
twoeths approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@twoeths twoeths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@g11tech g11tech merged commit 4fd72b2 into unstable May 23, 2023
11 checks passed
@g11tech g11tech deleted the g11tech/archive-state branch May 23, 2023 06:53
@twoeths twoeths mentioned this pull request May 30, 2023
Closed
twoeths added a commit that referenced this pull request May 30, 2023
@twoeths
Revert "refactor: change archiving strategy to always store last fina…
2d064d2 
…lized (#5520)"

This reverts commit 4fd72b2.
twoeths
twoeths reviewed May 31, 2023
View reviewed changes
packages/beacon-node/src/chain/archiver/archiveStates.ts
(Math.floor(finalized.epoch / archiveStateEpochFrequency) - 1) * archiveStateEpochFrequency
);
// Only check the current and previous intervals
const minEpoch = Math.max(0, (Math.floor(finalized.epoch / frequency) - 1) * frequency);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dapplion @g11tech most of the time frequency=32 and we store finalized state every 32 epochs which caused the increased DB size, we should use archiveStateEpochFrequency here to clean more states to keep stable db size like the old strategy

v1.9.0-rc.0
Screenshot 2023-05-31 at 14 28 25

v1.8.0
Screenshot 2023-05-31 at 14 29 00

@twoeths twoeths mentioned this pull request May 31, 2023
Merged
twoeths added a commit that referenced this pull request May 31, 2023
@twoeths
fix: revert PR-5520 (#5592)
888c599 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
34a9699 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
e9dcea0 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
6eb9221 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
1a83897 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
51cbfa8 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
5f2eec9 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
5f4ca9e 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
d8670a8 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
cd55a12 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
b4d36b2 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
2da28d8 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
b2a3949 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
3a81a61 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
2101f95 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
1ee9ccb 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
27fb795 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
9260972 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
5bced4e 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
twoeths added a commit that referenced this pull request Jun 6, 2023
@twoeths
fix: revert PR-5520 (#5592)
7d62137 
* Revert "refactor: change archiving strategy to always store last finalized (#5520)"

This reverts commit 4fd72b2.

* chore: add more log to StatesArchiver
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoeths twoeths twoeths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@g11tech @wemeetagain @twoeths