fix: block value in produceBlockV3 should be in wei

[ensi321]

Description

Currently consensusBlockValue is in Gwei. To align with executionPayloadValue, block value is converted into Wei.

Note that values in RewardCache will still be in Gwei for the purpose of rewards API, which is denominated in Gwei.

• Closes Payload and block values should be in wei #6259
• spec PR Clarify that payload & block values are in Wei ethereum/beacon-APIs#400

[codecov]

Codecov Report

Merging #6286 (3c20598) into unstable (aa87c54) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #6286      +/-   ##
============================================
- Coverage     80.38%   80.38%   -0.01%     
============================================
  Files           202      202              
  Lines         19620    19619       -1     
  Branches       1176     1176              
============================================
- Hits          15771    15770       -1     
  Misses         3821     3821              
  Partials         28       28              

[nflaig]

Note that values in RewardCache will still be in Gwei for the purpose of rewards API, which is denominated in Gwei.

You are right the spec states to use gwei for rewards API but isn't this a bit odd? I feel like we should use the same unit across all APIs

[ensi321]

Note that values in RewardCache will still be in Gwei for the purpose of rewards API, which is denominated in Gwei.

You are right the spec states to use gwei for rewards API but isn't this a bit odd? I feel like we should use the same unit across all APIs

Yea I have pointed this out in api channel on Discord.

I think we either be inconsistent with payload value in the same endpoint, or be inconsistent with reward value from other endpoints. It's unideal either way.

[ensi321]

I just realized the beacon API PR that proposes block value in Wei hasn't been merged yet. We can hold off merging this until that PR is merged.

[nflaig]

We can hold off merging this until that PR is merged.

yeah, let's wait a bit until there is a final decision on this and the spec PR is merged

[g11tech]

blocked till the spec is updated

[g11tech]

@ensi321 can you also link the spec PR in the description (it may be in the linked issue but direct linking here is more useful)

[ensi321]

yeah, let's wait a bit until there is a final decision on this and the spec PR is merged

PR is merged. I believe we can continue reviewing this PR @nflaig @g11tech

[nflaig]

lgtm

[wemeetagain]

lgtm

spec PR now merged

[wemeetagain]

🎉 This PR is included in v1.15.0 🎉