fix: correct total block value in publish block log #6336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6336 +/- ##
=========================================
Coverage 76.59% 76.59%
=========================================
Files 248 248
Lines 25907 25907
Branches 1448 1448
=========================================
Hits 19844 19844
Misses 6033 6033
Partials 30 30 |
nflaig
changed the title
consensusBlockValue unit in debug log
nflaig
approved these changes
Jan 22, 2024
wemeetagain
approved these changes
Jan 22, 2024
|
🎉 This PR is included in v1.15.0 🎉 |
jeluard
pushed a commit
to jeluard/lodestar
that referenced
this pull request
Jan 30, 2024
* Fix consensusBlockValue unit in debug log * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
consensusBlockValueshould be in wei and not gwei. Previous PR #6286 fixed the unit but forgot to change the unit when calculating the total block value (totalBlockValue) in the publish block log which this PR aims to fix.Closes #6316