feat: track timings of various stages of block import #6439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g11tech
commented
Feb 16, 2024
| @@ -133,19 +133,28 @@ function getDefaultHandlers(modules: ValidatorFnsModules, options: GossipHandler | |||
| const blockInputMeta = | |||
| config.getForkSeq(signedBlock.message.slot) >= ForkSeq.deneb ? blockInputRes.blockInputMeta : {}; | |||
|
|
|||
| metrics?.gossipBlock.receivedToGossipValidate.observe(recvToVal); | |||
There was a problem hiding this comment.
this previously was incorrect because it was observing the latency not the actual rec to validation time, fixed below
g11tech
commented
Feb 16, 2024
|
|
||
| const {blockInput, blockInputMeta} = chain.seenGossipBlockInput.getGossipBlockInput(config, { | ||
| type: GossipedInputType.blob, | ||
| blobSidecar, | ||
| blobBytes, | ||
| }); | ||
|
|
||
| metrics?.gossipBlob.receivedToGossipValidate.observe(recvToVal); |
There was a problem hiding this comment.
this previously was incorrect because it was observing the latency not the actual rec to validation time, fixed below
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6439 +/- ##
============================================
- Coverage 61.70% 61.64% -0.07%
============================================
Files 553 553
Lines 57858 57918 +60
Branches 1829 1829
============================================
Hits 35702 35702
- Misses 22119 22179 +60
Partials 37 37 |
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
reviewed
Feb 17, 2024
matthewkeil
requested changes
Feb 17, 2024
wemeetagain
changed the title
wemeetagain
approved these changes
Feb 17, 2024
|
🎉 This PR is included in v1.16.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to track correctly various stages of block import to figure out why we have verify latency for e.g. and to uncover any possible optimizations
also
dashboard for new values coming up in followup PR