-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: track timings of various stages of block import #6439
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -115,7 +115,7 @@ function getDefaultHandlers(modules: ValidatorFnsModules, options: GossipHandler | |
const forkTypes = config.getForkTypes(slot); | ||
const blockHex = prettyBytes(forkTypes.BeaconBlock.hashTreeRoot(signedBlock.message)); | ||
const delaySec = chain.clock.secFromSlot(slot, seenTimestampSec); | ||
const recvToVal = Date.now() / 1000 - seenTimestampSec; | ||
const recvToValLatency = Date.now() / 1000 - seenTimestampSec; | ||
|
||
// always set block to seen cache for all forks so that we don't need to download it | ||
const blockInputRes = chain.seenGossipBlockInput.getGossipBlockInput(config, { | ||
|
@@ -133,19 +133,27 @@ function getDefaultHandlers(modules: ValidatorFnsModules, options: GossipHandler | |
const blockInputMeta = | ||
config.getForkSeq(signedBlock.message.slot) >= ForkSeq.deneb ? blockInputRes.blockInputMeta : {}; | ||
|
||
metrics?.gossipBlock.receivedToGossipValidate.observe(recvToVal); | ||
logger.verbose("Received gossip block", { | ||
slot: slot, | ||
root: blockHex, | ||
curentSlot: chain.clock.currentSlot, | ||
peerId: peerIdStr, | ||
delaySec, | ||
recvToVal, | ||
...blockInputMeta, | ||
}); | ||
|
||
try { | ||
await validateGossipBlock(config, chain, signedBlock, fork); | ||
|
||
const recvToValidation = Date.now() / 1000 - seenTimestampSec; | ||
const validationTime = recvToValidation - recvToValLatency; | ||
|
||
metrics?.gossipBlock.gossipValidation.recvToValidation.observe(recvToValidation); | ||
metrics?.gossipBlock.gossipValidation.validationTime.observe(validationTime); | ||
|
||
logger.debug("Received gossip block", { | ||
slot: slot, | ||
root: blockHex, | ||
curentSlot: chain.clock.currentSlot, | ||
peerId: peerIdStr, | ||
delaySec, | ||
...blockInputMeta, | ||
recvToValLatency, | ||
recvToValidation, | ||
validationTime, | ||
}); | ||
|
||
return blockInput; | ||
} catch (e) { | ||
if (e instanceof BlockGossipError) { | ||
|
@@ -177,28 +185,35 @@ function getDefaultHandlers(modules: ValidatorFnsModules, options: GossipHandler | |
const blockHex = prettyBytes(blockRoot); | ||
|
||
const delaySec = chain.clock.secFromSlot(slot, seenTimestampSec); | ||
const recvToVal = Date.now() / 1000 - seenTimestampSec; | ||
const recvToValLatency = Date.now() / 1000 - seenTimestampSec; | ||
|
||
const {blockInput, blockInputMeta} = chain.seenGossipBlockInput.getGossipBlockInput(config, { | ||
type: GossipedInputType.blob, | ||
blobSidecar, | ||
blobBytes, | ||
}); | ||
|
||
metrics?.gossipBlob.receivedToGossipValidate.observe(recvToVal); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this previously was incorrect because it was observing the latency not the actual rec to validation time, fixed below |
||
logger.verbose("Received gossip blob", { | ||
slot: slot, | ||
root: blockHex, | ||
curentSlot: chain.clock.currentSlot, | ||
peerId: peerIdStr, | ||
delaySec, | ||
recvToVal, | ||
gossipIndex, | ||
...blockInputMeta, | ||
}); | ||
|
||
try { | ||
await validateGossipBlobSidecar(chain, blobSidecar, gossipIndex); | ||
const recvToValidation = Date.now() / 1000 - seenTimestampSec; | ||
const validationTime = recvToValidation - recvToValLatency; | ||
|
||
metrics?.gossipBlob.recvToValidation.observe(recvToValidation); | ||
metrics?.gossipBlob.validationTime.observe(validationTime); | ||
|
||
logger.debug("Received gossip blob", { | ||
slot: slot, | ||
root: blockHex, | ||
curentSlot: chain.clock.currentSlot, | ||
peerId: peerIdStr, | ||
delaySec, | ||
gossipIndex, | ||
...blockInputMeta, | ||
recvToValLatency, | ||
recvToValidation, | ||
validationTime, | ||
}); | ||
|
||
return blockInput; | ||
} catch (e) { | ||
if (e instanceof BlobSidecarGossipError) { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this previously was incorrect because it was observing the latency not the actual rec to validation time, fixed below