Skip to content
This repository has been archived by the owner on Oct 25, 2022. It is now read-only.

M5 - Make mvp demo mpa(multi-page application) #205

Merged
merged 8 commits into from
Apr 15, 2022

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Apr 8, 2022

Summary of changes
Changes introduced in this pull request:

  • Converts the single-page demo to multi-page so that more functionalities can be integrated, e.g. readme, send transaction, etc.
  • Integrate with tailwindcss
  • Make chrome extension without sandboxing (requires chrome canary for now)
  • Render project readme.md on index page
  • Create page skeleton for graphql demo
  • Build chrome extension mv2 for chrome stable / edge and firefox
  • Instructions on using the extension chrome canary/stable, edge and firefox

Reference issue to close (if applicable)

Closes

Other information and links

@hanabi1224 hanabi1224 changed the title Make mvp demo mpa(multi-page application) M5 - Make mvp demo mpa(multi-page application) Apr 8, 2022
@hanabi1224 hanabi1224 added this to the m5 milestone Apr 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2022

Codecov Report

Merging #205 (6deb15d) into main (82ffe52) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files         101      101           
  Lines        4341     4341           
=======================================
  Hits         3701     3701           
  Misses        640      640           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82ffe52...6deb15d. Read the comment docs.

@willemolding
Copy link
Contributor

Any idea how much effort would be required to support Firefox? As I understand:

  • Firefox extensions don't support manifest v3 so we would need to switch to v2
  • I think Firefox supports unsafe-wasm-eval in extensions (need to confirm this)

There is no Chrome Canary for Linux, so if we continue down the current path we will only support non-linux chrome users.

@hanabi1224
Copy link
Contributor Author

hanabi1224 commented Apr 13, 2022

@willemolding

That's a good suggestion, I've added extension mv2 support.

so we would need to switch to v2

v2 cannot be published to chrome extension store anymore, which is the deal-breaker

There is no Chrome Canary for Linux

According to posts in the Chrome mail list, this is a bug fix and will roll out to chrome stable soon. MV3 is required for publishing to the Chrome extension store, which is the plan made by our partner

Copy link
Contributor

@creativcoder creativcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my local for v2 and as a web page. Looking great!

@hanabi1224 hanabi1224 merged commit 00b23eb into ChainSafe:main Apr 15, 2022
@hanabi1224 hanabi1224 deleted the mvp-mpa branch April 15, 2022 02:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants