Skip to content
This repository has been archived by the owner on Oct 25, 2022. It is now read-only.

Willem/tidy deserializer api #62

Merged
merged 5 commits into from Oct 29, 2021
Merged

Conversation

willemolding
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Uses type state pattern to:
    • simplify the implementation of the bin-prot deserializer
    • Improve its API
    • Move some runtime checks to compile time (woop!) making the de-serialization more efficient

Copy link
Contributor

@creativcoder creativcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see type state pattern being used here! 🎊

@codecov-commenter
Copy link

Codecov Report

Merging #62 (18cca17) into main (1c5432b) will increase coverage by 0.20%.
The diff coverage is 88.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   89.02%   89.22%   +0.20%     
==========================================
  Files          44       44              
  Lines        2796     2691     -105     
==========================================
- Hits         2489     2401      -88     
+ Misses        307      290      -17     
Impacted Files Coverage Δ
bin-prot/src/de.rs 93.65% <82.35%> (+3.20%) ⬆️
bin-prot/src/loose_deserializer.rs 92.66% <89.74%> (+0.84%) ⬆️
bin-prot/tests/layouts.rs 98.79% <100.00%> (ø)
test-serialization/src/lib.rs 99.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c5432b...18cca17. Read the comment docs.

@willemolding willemolding merged commit c17163d into main Oct 29, 2021
@willemolding willemolding deleted the willem/tidy-deserializer-api branch October 29, 2021 00:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants