Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Ability to Correctly Parse FunctionName From Typescript Methods… #57

Merged
merged 2 commits into from
May 21, 2019
Merged

Added Ability to Correctly Parse FunctionName From Typescript Methods… #57

merged 2 commits into from
May 21, 2019

Conversation

WretchedDade
Copy link
Contributor

…/Functions

  • Updated namedFunctionDeclarationRegex to Allow any Character rather than just spaces after closing )
  • Updated regex used when parsing out function name to strip out typescript access modifiies and the export keywork in addition to the async word already being striped out
  • Updated test to cover new test cases

@WretchedDade
Added Ability to Correctly Parse FunctionName From Typescript Methods…
8853372 
…/Functions

* Updated namedFunctionDeclarationRegex to Allow any Character rather than just spaces after closing )
* Updated regex used when parsing out function name to strip out typescript access modifiies and the export keywork in addition to the async word already being striped out
* Updated test to cover new test cases
@WretchedDade WretchedDade mentioned this pull request May 15, 2019
Closed
@Chakroun-Anas Chakroun-Anas merged commit 51c898a into Chakroun-Anas:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WretchedDade @Chakroun-Anas