Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add reject #511

Closed
wants to merge 1 commit into from
Closed

[FEATURE] Add reject #511

wants to merge 1 commit into from

Conversation

Chalarangelo
Copy link
Owner

Description

Lodash #100 -> https://lodash.com/docs/4.17.4#reject

What does your PR belong to?

  • Website
  • Snippets
  • General / Things regarding the repository (like CI Integration)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking improvement of a snippet)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have checked that the changes are working properly
  • I have checked that there isn't any PR doing the same
  • I have read the CONTRIBUTING document.

@kingdavidmartins kingdavidmartins mentioned this pull request Jan 8, 2018
Closed
skatcat31
skatcat31 reviewed Jan 8, 2018
View reviewed changes
snippets/reject.md
Use `Array.filter()` and the not operator (`!`) to return the elements in the array for which `fn` returns `false`.

```js
const reject = (arr, fn) => arr.filter((e,i,arr) => !fn(e,i,arr));

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@iamsoorena
Copy link
Contributor

I just approved that it works right. I have no suggestion about whether or not we should add this. :)

@Chalarangelo
Copy link
Owner Author

I'm closing and marking in #100 that this will not be implemented. Might mark a few more as well.

@Chalarangelo Chalarangelo deleted the object-reject branch January 8, 2018 23:10
@lock
Copy link

lock bot commented Dec 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for any follow-up tasks.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@skatcat31 skatcat31 skatcat31 left review comments

@mariastervic mariastervic mariastervic left review comments

@iamsoorena iamsoorena iamsoorena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Chalarangelo @iamsoorena @skatcat31 @mariastervic