Page listant les notifications #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </li> | ||
| <li> | ||
| <a href="{% url "notification-list" %}?order=desc{% if type %}&type={{ type }}{% endif %}{% if sort %}&sort={{ sort }}{% endif %}" class="ico-after move {% if order == "desc" %}selected{% endif %}"> | ||
| {% trans 'Déscendant' %} |
…or desc. 1. Creates SortMixin in utils/mixins.py file to have a generic mixin. 2. Uses SortMixin in NotificationListView and configure it. 3. Adds all test cases about the sort. Closes #12
1. Creates FilterMixin in utils/mixins.py file to have a generic mixin. 2. Uses FilterMixin in NotificationListView and configure it. 3. Adds all test cases about the filter. Closes #12
|
Attention, à ne pas merger, les tests ne passent pas parce que les tests Django, c'est tout pourrie ... |
|
@ChantyTaguan @Situphen Si ça vous va, merge ? |
ChantyTaguan
added a commit
that referenced
this pull request
May 9, 2015
Page listant les notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12