Fixes for null parameter #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clearly the behavior of Is this the fix of |
|
I realize this is the fix of |
Fixed an issue that stopped reading parameters when receiving not registered avatar parameters on the avatar config file.
kathibeepboop
commented
Nov 11, 2022
| } | ||
| catch (Exception) | ||
| { | ||
| // eat exception |
There was a problem hiding this comment.
i agree on that ;) just eat it
|
Sorry i was kinda busy the last time ;) Thank you reviewing the PR. Its a better way to implement it as "TryGet", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heyo,
there was a little bug which caused the osc params to not be updated anymore.
In my case there was an Animator param that has been updated, which was not in the VRC params.
This method just ignores null values and doesn´t fire the update event ;)