Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Change Request] Prefix the attrs values. #45

Open
leobrujah opened this issue Aug 8, 2019 · 3 comments
Open

[Change Request] Prefix the attrs values. #45

leobrujah opened this issue Aug 8, 2019 · 3 comments
Labels
enhancement

Comments

@leobrujah
Copy link

Description:

Would be possible to prefix the attrs values in order to not conflict with other libraries?

At the moment, the attribute attr/viewType conflicts with one with the same name in the new Androidx Media2 library androidx.media2:media2-widget. Prefixing to something like pin_viewType pin_backgroundColor would almost 100% prevent conflict issues of attributes.
@PembaTamang
Copy link

same issue here

ChaosLeung added a commit that referenced this issue Aug 21, 2020
@ChaosLeung
[Modify] Add prefix to custom attrs #45
e334c71
@quensh93
Copy link

jetified-pinview-1.4.3/res/values/values.xml:14:5-32:25: AAPT: error: duplicate value for resource 'attr/viewType' with config ''.

still there

@jemshit
Copy link

jemshit commented Jan 28, 2021

This commit exists on "develop" branch and must be added (cherrypick) to "master" branch as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jemshit @leobrujah @ChaosLeung @quensh93 @PembaTamang