Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted keywords to reduce false positives. #100

Merged
merged 5 commits into from Nov 8, 2015
Merged

Adjusted keywords to reduce false positives. #100

merged 5 commits into from Nov 8, 2015

Conversation

BrockA
Copy link
Contributor

@BrockA BrockA commented Nov 8, 2015

Removed "black magic" and adjusted "weight loss" to reduce false positives.

Regarding "weight loss":


For "black magic" see: - Starting [here, on Tavern](http://chat.meta.stackexchange.com/transcript/message/4165391#4165391) and - [Here, on Charcoal HQ](http://chat.stackexchange.com/transcript/message/25247400#25247400)

Removed "black magic" and adjusted "weight loss" to reduce false positives.

Regarding "weight loss":

 - It was causing too many false positives due to [the term *deadweight loss*](https://en.wikipedia.org/wiki/Deadweight_loss), which frequently occurs in economics.
 - Reference [this chat on Charcoal HQ](http://chat.stackexchange.com/transcript/message/25247160#25247160)
 - Tweaked the regex to only match when word starts with "weight".

<br>
For "black magic" see:

 - Starting [here, on Tavern](http://chat.meta.stackexchange.com/transcript/message/4165391#4165391)
  and  
 - [Here, on Charcoal HQ](http://chat.stackexchange.com/transcript/message/25247400#25247400)
@Manishearth
Copy link
Contributor

I'd rather reduce the number of sites "black magic" applies on.

There is a recurring spammer who posts about black magic.

@BrockA
Copy link
Contributor Author

BrockA commented Nov 8, 2015

@Manishearth Okay, I'll investigate that. I've seen nothing but false positives for it so far.

Can we kill it for now while I look into the per-site thing?

@Manishearth
Copy link
Contributor

@ProgramFOX thoughts? Also on the addition to the privileged users list.

@BrockA
Copy link
Contributor Author

BrockA commented Nov 8, 2015

@Manishearth
Copy link
Contributor

"from Islam"

@BrockA
Copy link
Contributor Author

BrockA commented Nov 8, 2015

@Manishearth
Copy link
Contributor

Yes, I wonder what he says in light of the "recurring spammer" thing

@BrockA
Copy link
Contributor Author

BrockA commented Nov 8, 2015

Can you point out some of that spam? Might be able to fix it another way, maybe...

@Manishearth
Copy link
Contributor

Well, it's all gone now 😄

It's similar to the vashikaran spam. It was one of the reasons we created smokey in the first place.

@BrockA
Copy link
Contributor Author

BrockA commented Nov 8, 2015

@Manishearth Okay, I put the check back in for now.
Sure those other BM spams wouldn't have been caught by another factor? (Links, etc.) because this keyword is 0 for 3 since I started noticing it.

@Manishearth
Copy link
Contributor

Not sure. r=me once travis passes

@BrockA
Copy link
Contributor Author

BrockA commented Nov 8, 2015

Okay @Manishearth, all checks have passed.

Manishearth added a commit that referenced this pull request Nov 8, 2015
Adjusted keywords to reduce false positives.
@Manishearth Manishearth merged commit 8627734 into Charcoal-SE:master Nov 8, 2015
@BrockA
Copy link
Contributor Author

BrockA commented Nov 8, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants