Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Command List #47

Closed
wants to merge 4 commits into from
Closed

Basic Command List #47

wants to merge 4 commits into from

Conversation

JC3
Copy link
Contributor

@JC3 JC3 commented Mar 24, 2015

Basic command list. Untested. Not a full help system.

Basic command list. Untested. Not a full help system.
@Undo1
Copy link
Member

Undo1 commented Mar 24, 2015

Looks like Flake8 is unhappy with you:

E       Failed: INDENTATION CHECK FAILED: found tab in chatcommunicate.py at line 283. Please use spaces as indentation, using tabs is inconsistent with the rest of the indentation and might break SmokeDetector.

It gets me too :P

JC3 added 3 commits March 24, 2015 17:44
Spaces
This reverts commit 18c7b40.
@JC3
Copy link
Contributor Author

JC3 commented Mar 24, 2015

I'm confused by git. Was the second reject on the tabs -> spaces change an auto-reject because I screwed something up, or an explicit reject because it was an unwanted change? (I have no arguments for making this change, it's fine if it's rejected, I'm just trying to figure out how the pull system works.)

@csnardi
Copy link
Contributor

csnardi commented Mar 24, 2015

Merged in 4c8886d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants