Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad_keywords.txt: Add Nigerian phone number pattern #481

Merged
merged 3 commits into from
Jan 25, 2017

Conversation

tripleee
Copy link
Member

@tripleee
Copy link
Member Author

Tangentially notice also the spurious second NAA result, what's up with that?

http://chat.stackexchange.com/transcript/message/34997774#34997774

@tripleee
Copy link
Member Author

This SEDE query finds 21 potential FPs in all of Stack Overflow: https://data.stackexchange.com/stackoverflow/query/619660/nigerian-phones-take-2

@ArtOfCode-
Copy link
Member

Does this not get caught by the phone number in {} reason?

@tripleee
Copy link
Member Author

Nope; as noted in the very first comment in the chat discussion I linked, that only gets applied to the title.

Copy link
Member

@ArtOfCode- ArtOfCode- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[0-9] can be \d (digit class). Should probably also put a maximum on the repetition operator - 14 is a common max length for phone numbers, so {8,11} would be okay.

tripleee added 2 commits January 25, 2017 18:22
@tripleee
Copy link
Member Author

I am aware of no particular reason to prefer \d over [0-9] but sure. (It complicates matters if you want to use Metasmoke's somewhat less capable MySQL regex engine with these patterns.)

@ArtOfCode- ArtOfCode- merged commit 7a4d74c into Charcoal-SE:master Jan 25, 2017
@ArtOfCode-
Copy link
Member

ArtOfCode- commented Jan 25, 2017

@tripleee I suggested \d because semantics. It's always good to be semantically correct where we can.

@tripleee tripleee deleted the nigerian-phones branch January 25, 2017 16:28
@tripleee
Copy link
Member Author

tripleee commented Jan 27, 2017

This was broken; fix in PR484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants