bad_keywords:txt: Fix plussed phone numbers #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were not working, because the leading plus is consumed by the word boundary condition in the code so we can't match that directly, but we can say "if we just skipped a plus sign" with a lookbehind.
|
See also discussion about design guidance at http://chat.stackexchange.com/transcript/message/35038988#35038988 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were not working, because the leading plus is consumed by the word boundary condition in the code, so we can't match that directly, but we can say "if we just skipped a plus sign" with a lookbehind.
I included a couple of comments in the text file which are simply never going to match anything; but down the line, we might want to add code to skip comments in the file, or just remove these lines.