Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tpu feedback from MS review #238

Closed
JohnMiliter opened this issue Aug 10, 2017 · 3 comments
Closed

Tpu feedback from MS review #238

JohnMiliter opened this issue Aug 10, 2017 · 3 comments
Assignees

Comments

@JohnMiliter
Copy link

I like the review interface, but I am tired of going back to chat later after reviewing to manually blacklist spammers via the !!/addblu command

I think it would be nice if the spam / abusive button in the metasmoke review gave tpu feedback instead of tp feedback (I tested it, and unless another user was messing with the blacklist in another room, or there is a very long delay, that button does not auto-blacklist users).
If this was made the case, a separate "tp" or "vandalism" button should be added.

@JohnMiliter
Copy link
Author

(Sorry if posted in the wrong place)

@tripleee
Copy link
Member

I'm thinking this is because of an architectural disconnect -- Smoke Detector runs in chat, Metasmoke doesn't, and so it would have to grow a chat interface after all in order to communicate the blacklisting to Smoke Detector.

@angussidney
Copy link
Member

angussidney commented Aug 10, 2017

AFAIK the full functionality is there to blacklist stuff via the MS websocket (because that's how the API blacklists stuff), it's just that it needs to be implemented for review.

Edit: here we go https://github.com/Charcoal-SE/SmokeDetector/blob/master/metasmoke.py#L94

@Undo1 Undo1 self-assigned this Aug 12, 2017
@Undo1 Undo1 closed this as completed in 650367f Aug 12, 2017
tripleee pushed a commit to tripleee/metasmoke that referenced this issue Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants