Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impossible to tag untagged domains in review #670

Closed
double-beep opened this issue Aug 20, 2019 · 1 comment · Fixed by #671
Closed

Impossible to tag untagged domains in review #670

double-beep opened this issue Aug 20, 2019 · 1 comment · Fixed by #671
Assignees
@makyen
Labels
area: review metasmoke's review system and associated things type: bug Buggy or otherwise incorrect behaviour.

Comments

@double-beep
Copy link
Member

Some time ago, the untagged domains review queue looked like:

image

However, now, it looks like it is broken:

image

When clicking add, the system adds automatically two # tags. Can this be fixed?

The console throws the following error:

Unhandled promise rejection TypeError: Unable to get property 'firstChild' of undefined or null reference
@double-beep double-beep changed the title How can I add tags in the untagged domains review queue? Impossible to tag untagged domains in review Aug 20, 2019
@makyen makyen self-assigned this Aug 20, 2019
@makyen makyen added area: review metasmoke's review system and associated things type: bug Buggy or otherwise incorrect behaviour. labels Aug 20, 2019
@makyen
Copy link
Contributor

makyen commented Aug 20, 2019 •
edited

This is an issue in code I added in #658. The issue is that the code I added is running on the untagged domains review page when it was intended only for the posts review page. I'll create a fix.

makyen added a commit to makyen/Charcoal-SE-metasmoke that referenced this issue Aug 20, 2019
@makyen
Review pages: run JS code per review type; fix Charcoal-SE#670
654bf98
makyen added a commit to makyen/Charcoal-SE-metasmoke that referenced this issue Aug 21, 2019
@makyen
Review pages: run JS code per review type; fix Charcoal-SE#670
1e64dc7
@makyen makyen mentioned this issue Aug 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@makyen makyen

Labels
area: review metasmoke's review system and associated things type: bug Buggy or otherwise incorrect behaviour.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Review pages: title and history for all review types Charcoal-SE/metasmoke
2 participants
@makyen @double-beep