Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metasmoke is doing things multiple times #775

Open
user12986714 opened this issue Jul 16, 2020 · 6 comments · Fixed by #935
Open

Metasmoke is doing things multiple times #775

user12986714 opened this issue Jul 16, 2020 · 6 comments · Fixed by #935

Comments

@user12986714
Copy link
Contributor

It appears that when performing some actions on metasmoke, it will be automatically repeated for some integer times:

  • Create feedback on post: sometimes 2
  • Add domain link: always 3
  • Auto creation of domain: sometimes 2

This is probably not the intended behaviour of metasmoke.

Related:
https://metasmoke.erwaysoftware.com/data/sql/queries/42-duplicate-domain-tags-405
https://metasmoke.erwaysoftware.com/data/sql/queries/207-duplicate-feedbacks

@ArtOfCode-
Copy link
Member

This is probably the same old JS bug that's existed forever, probably related to Turbolinks

@user12986714
Copy link
Contributor Author

Looks like this issue is now resolved.

@makyen
Copy link
Contributor

makyen commented Sep 20, 2020

The recent change I made to JavaScript event handlers may have reduced the problems, and solved some of them, but it did not resolve all of them. In particular, I can still create multiple feedbacks on the same post.

At least the multiple feedbacks, and some other issues, are the result of a user being permitted to rapidly click twice on the same control. There will be another set of JavaScript changes to resolve that, but I want to make sure the most recent change didn't result in any problems.

@makyen
Copy link
Contributor

makyen commented Mar 26, 2021

The feedback issue was addressed in PR #823 and PR #825.

@tripleee
Copy link
Member

Related? #563

@makyen makyen closed this as completed Jul 21, 2022
@makyen makyen reopened this Jul 21, 2022
@makyen
Copy link
Contributor

makyen commented Jul 21, 2022

Grumble, grumble, multiple things in one issue. :;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants