Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting a domain name should work when linking two related domains #941

Open
tripleee opened this issue Aug 21, 2022 · 1 comment
Open

Comments

@tripleee
Copy link
Member

This is such a minor nuisance that I didn't think much of it when the domain linking feature was badly wounded; but now that it basically works, it would be really nice if you could just paste the name of the domain you want to link to in the linking dialog box.

The way it currently works, you can paste, remove the last character, then select the correct domain from the dropdown. Take care to select the correct one; there will sometimes be candidates which share a substring match which are being offered up, too.

Something in there gets wedged sometimes, as well; a few times a day, I end up closing the tab where I opened the dialog, and starting over by reopening the domain page. Other times, it eventually comes back to life if you leave it open and go do something else for a while. I can't say how to repro this, though it's not impossible that fat-fingering the copy/paste somehow might be a contributing factor. I think I have still experienced this after the latest changes, but let me get back and check that still, probably within a few days.

I imagine this is a side effect of the logic to dynamically suggest completion candidates when you manually type the name of the target, but in our use case, chances are you already have it in your system clipboard, and don't really need this feature.

(I suppose this might be an upstream bug in the library we use; is this component using Turbolinks?)

Ideally, I hope metasmoke should ultimately be consistent in how keyboard completion works in different subcomponents. The autocompletion for tags when you assign them to a post or a domain has slightly different quirks, and so you have to learn different muscle memory behaviors for different contexts. I imagine this inconsistency will also be bewildering to some newcomers to the system.

makyen added a commit to makyen/Charcoal-SE-metasmoke that referenced this issue Aug 21, 2022
This should resolve the titular issue in Charcoal-SE#941 of pasting a
domain name in the new domain link dialog not triggering a
search and fill of the available domains.
@makyen
Copy link
Contributor

makyen commented Aug 21, 2022

The above PR/commit resolves the titular problem. The fix resolves the issue of not searching upon paste for the New Domain Link dialog and anywhere else we use that search extension.

However, the text of the above issue is substantially more expansive than just the issue of pasting not being an effective method of triggering a search (which is an extension MS adds to the bootstrap-select dialogs). It would help to have those problems in a separate issue or issues.

I've created Issue #943, Need to prevent re-performing some JavaScript page setup actions when they've already been performed, which covers a wide variety of problems which occur with navigation. The problems which are a result of that issue will mostly be when using the browser's forward and back functionality to navigate, but might also occur when revisiting a page through other navigation, depending on how the browser handles caching information from the previous visit. Unfortunately, until that issue is fully addressed, it's going to be difficult to separate out any problems which are not caused by it, but which require navigating around the site prior to the problem manifesting. I haven't seen anything associated with that issue manifest without previously performing a Turbolinks navigation from one page to another (not something a user generally chooses to do or not do, other than through an explicit page reload). So, if the more general issues which you've mentioned happen without previously navigating within that tab, then they are unlikely to be issue #943 (unless your browser is serving you a cached DOM, rather than a cached raw HTML fetch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants