Search for [^A-Za-z0-9] instead of the unsupported \W #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what code I wrote actually. I hope a Ruby developer understand my intention. lol. |
j-f1
reviewed
Mar 18, 2018
app/controllers/github_controller.rb
Outdated
| @@ -85,6 +85,7 @@ def pull_request_hook | |||
|
|
|||
| keywords.each do |keyword| | |||
| keyword = keyword[0] | |||
| keyword.gsub! '\W', '[ -]' | |||
There was a problem hiding this comment.
Does [^A-Za-z0-9] work? If so, we should use that since it’s more correct.
There was a problem hiding this comment.
Add an underscore to that class, but yeah
|
@ArtOfCode- @j-f1 Yep. Changes made. |
iBug
changed the title
|
Note: I do intend to review this, but a scroll through the changes tab doesn't give me confidence it's going to work... search is complicated and I'd like to actually pull and test locally before I give this a pass. |
|
Does the |
|
@j-f1 I'm afraid it's because MySQL does not support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MS has commented a lot of "0 TPs, 0 FPs", in Smokey's PRs. This should fix that wrong search.
P.S. This is my absolutely first lines of Ruby code so there may be very stupid syntax or usage errors. Please check them, Thanks.