Use actual reason count in historical accuracy check #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtOfCode-
requested changes
Jul 4, 2020
| @@ -55,7 +55,7 @@ def autoflag | |||
| fake_flag_condition = FlagCondition.new( | |||
| sites: Site.mains, | |||
| max_poster_rep: post.user_reputation, | |||
| min_reason_count: 1, | |||
| min_reason_count: len(post.reasons), | |||
There was a problem hiding this comment.
That... is not going to work. len is not Ruby.
ArtOfCode-
requested changes
Jul 4, 2020
Comment on lines
55
to
61
| post_reasons_count = 0 | ||
| post.reasons.each do |r| | ||
| post_reasons_count += 1 | ||
| fake_flag_condition = FlagCondition.new( | ||
| sites: Site.mains, | ||
| max_poster_rep: post.user_reputation, | ||
| min_reason_count: 1, | ||
| min_reason_count: post_reasons_count, |
There was a problem hiding this comment.
Ruby is not Python. You're writing Python-style Ruby, and... it's not going to work. You want post.reasons.count
There was a problem hiding this comment.
Well, I used post.reasons.count, and CI is not happy about it... On 9e77670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will hopefully make db queries faster/more accurate.