Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Toggle Data" option to demo charts. (#771 Support) #781

Merged

Conversation

ospr
Copy link
Contributor

@ospr ospr commented Feb 28, 2016

Added an option to the demo charts project view controllers to toggle the charts data to nil or default values. Used test each chart type for pull request #772 to verify that setting the data property causes the chart to properly treat the data as nil.

Note that this pull request includes changes from pr #772. pr #772 should be merged in first and then, if desired, this pr as well.

Changed ChartViewBase's _data property declaration from _data! to _data? to allow for setting the chart's data back to nil. Updated the code base to property handle _data as an optional value.
Added a "Toggle Data" option to each of the view controllers in the charts demo project. This option will either set the chart's data property to nil if toggled off or to the default data if toggled on.
danielgindi added a commit that referenced this pull request Feb 28, 2016
Add "Toggle Data" option to demo charts. (#771 Support)
@danielgindi danielgindi merged commit 796281d into ChartsOrg:master Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants